Skip to content

Commit

Permalink
pwm: lp3943: Use of_property_count_u32_elems() to get property length
Browse files Browse the repository at this point in the history
Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.

Signed-off-by: Rob Herring (Arm) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Uwe Kleine-König <[email protected]>
  • Loading branch information
robherring authored and Uwe Kleine-König committed Sep 5, 2024
1 parent f9ecc2f commit 75f0cb3
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/pwm/pwm-lp3943.c
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ static int lp3943_pwm_parse_dt(struct device *dev,
struct lp3943_platform_data *pdata;
struct lp3943_pwm_map *pwm_map;
enum lp3943_pwm_output *output;
int i, err, proplen, count = 0;
int i, err, count = 0;
u32 num_outputs;

if (!node)
Expand All @@ -234,11 +234,8 @@ static int lp3943_pwm_parse_dt(struct device *dev,
*/

for (i = 0; i < LP3943_NUM_PWMS; i++) {
if (!of_get_property(node, name[i], &proplen))
continue;

num_outputs = proplen / sizeof(u32);
if (num_outputs == 0)
num_outputs = of_property_count_u32_elems(node, name[i]);
if (num_outputs <= 0)
continue;

output = devm_kcalloc(dev, num_outputs, sizeof(*output),
Expand Down

0 comments on commit 75f0cb3

Please sign in to comment.