Skip to content

Commit

Permalink
opp: replace usage of found with dedicated list iterator variable
Browse files Browse the repository at this point in the history
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <[email protected]>
Signed-off-by: Viresh Kumar <[email protected]>
  • Loading branch information
Jakob-Koschel authored and vireshk committed Apr 11, 2022
1 parent 543256d commit 95073b7
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/opp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1486,26 +1486,25 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_put);
*/
void dev_pm_opp_remove(struct device *dev, unsigned long freq)
{
struct dev_pm_opp *opp;
struct dev_pm_opp *opp = NULL, *iter;
struct opp_table *opp_table;
bool found = false;

opp_table = _find_opp_table(dev);
if (IS_ERR(opp_table))
return;

mutex_lock(&opp_table->lock);

list_for_each_entry(opp, &opp_table->opp_list, node) {
if (opp->rate == freq) {
found = true;
list_for_each_entry(iter, &opp_table->opp_list, node) {
if (iter->rate == freq) {
opp = iter;
break;
}
}

mutex_unlock(&opp_table->lock);

if (found) {
if (opp) {
dev_pm_opp_put(opp);

/* Drop the reference taken by dev_pm_opp_add() */
Expand Down

0 comments on commit 95073b7

Please sign in to comment.