Skip to content

Commit

Permalink
[SPARC32]: Add irqflags.h to sparc32 and use it from generic code.
Browse files Browse the repository at this point in the history
Added asm-sparc/irqflags.h and moved irq related code from system.h to it.
Renamed local_irq functions to raw_local_irq in irq.c.
Modified system.h to include linux/irqflags.h which includes asm/irqflags.h.
Added TRACE_IRQFLAGS_SUPPORT to Kconfig.debug.

This is the first step in adding IRQ-flags state tracing as outlined in
Documentation/irqflags-tracing.txt.  These changes should be harmless
because they just move things around and rename them.

The next step is making the lowlevel entry code modifications which
to be honest are beyond my capabilities at this point.

Boot tested on an ss20 running an SMP kernel.

Signed-off-by: Robert Reif <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
IOBYTE authored and David S. Miller committed Oct 14, 2007
1 parent 72be7e5 commit e8dd161
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 26 deletions.
4 changes: 4 additions & 0 deletions arch/sparc/Kconfig.debug
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
menu "Kernel hacking"

config TRACE_IRQFLAGS_SUPPORT
bool
default y

source "lib/Kconfig.debug"

config DEBUG_STACK_USAGE
Expand Down
12 changes: 6 additions & 6 deletions arch/sparc/kernel/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
#define SMP_NOP2
#define SMP_NOP3
#endif /* SMP */
unsigned long __local_irq_save(void)
unsigned long __raw_local_irq_save(void)
{
unsigned long retval;
unsigned long tmp;
Expand All @@ -74,7 +74,7 @@ unsigned long __local_irq_save(void)
return retval;
}

void local_irq_enable(void)
void raw_local_irq_enable(void)
{
unsigned long tmp;

Expand All @@ -89,7 +89,7 @@ void local_irq_enable(void)
: "memory");
}

void local_irq_restore(unsigned long old_psr)
void raw_local_irq_restore(unsigned long old_psr)
{
unsigned long tmp;

Expand All @@ -105,9 +105,9 @@ void local_irq_restore(unsigned long old_psr)
: "memory");
}

EXPORT_SYMBOL(__local_irq_save);
EXPORT_SYMBOL(local_irq_enable);
EXPORT_SYMBOL(local_irq_restore);
EXPORT_SYMBOL(__raw_local_irq_save);
EXPORT_SYMBOL(raw_local_irq_enable);
EXPORT_SYMBOL(raw_local_irq_restore);

/*
* Dave Redman ([email protected])
Expand Down
39 changes: 39 additions & 0 deletions include/asm-sparc/irqflags.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/*
* include/asm-sparc/irqflags.h
*
* IRQ flags handling
*
* This file gets included from lowlevel asm headers too, to provide
* wrapped versions of the local_irq_*() APIs, based on the
* raw_local_irq_*() functions from the lowlevel headers.
*/
#ifndef _ASM_IRQFLAGS_H
#define _ASM_IRQFLAGS_H

#ifndef __ASSEMBLY__

extern void raw_local_irq_restore(unsigned long);
extern unsigned long __raw_local_irq_save(void);
extern void raw_local_irq_enable(void);

static inline unsigned long getipl(void)
{
unsigned long retval;

__asm__ __volatile__("rd %%psr, %0" : "=r" (retval));
return retval;
}

#define raw_local_save_flags(flags) ((flags) = getipl())
#define raw_local_irq_save(flags) ((flags) = __raw_local_irq_save())
#define raw_local_irq_disable() ((void) __raw_local_irq_save())
#define raw_irqs_disabled() ((getipl() & PSR_PIL) != 0)

static inline int raw_irqs_disabled_flags(unsigned long flags)
{
return ((flags & PSR_PIL) != 0);
}

#endif /* (__ASSEMBLY__) */

#endif /* !(_ASM_IRQFLAGS_H) */
22 changes: 2 additions & 20 deletions include/asm-sparc/system.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

#ifndef __ASSEMBLY__

#include <linux/irqflags.h>

/*
* Sparc (general) CPU types
*/
Expand Down Expand Up @@ -164,26 +166,6 @@ extern void fpsave(unsigned long *fpregs, unsigned long *fsr,
"o0", "o1", "o2", "o3", "o7"); \
} while(0)
/*
* Changing the IRQ level on the Sparc.
*/
extern void local_irq_restore(unsigned long);
extern unsigned long __local_irq_save(void);
extern void local_irq_enable(void);

static inline unsigned long getipl(void)
{
unsigned long retval;

__asm__ __volatile__("rd %%psr, %0" : "=r" (retval));
return retval;
}

#define local_save_flags(flags) ((flags) = getipl())
#define local_irq_save(flags) ((flags) = __local_irq_save())
#define local_irq_disable() ((void) __local_irq_save())
#define irqs_disabled() ((getipl() & PSR_PIL) != 0)

/* XXX Change this if we ever use a PSO mode kernel. */
#define mb() __asm__ __volatile__ ("" : : : "memory")
#define rmb() mb()
Expand Down

0 comments on commit e8dd161

Please sign in to comment.