Skip to content

Commit

Permalink
tracing/kprobes: Fix the order of argument descriptions
Browse files Browse the repository at this point in the history
The order of descriptions should be consistent with the argument list of
the function, so "kretprobe" should be the second one.

int __kprobe_event_gen_cmd_start(struct dynevent_cmd *cmd, bool kretprobe,
                                 const char *name, const char *loc, ...)

Link: https://lore.kernel.org/all/[email protected]/

Fixes: 2a588dd ("tracing: Add kprobe event command generation functions")
Suggested-by: Mukesh Ojha <[email protected]>
Signed-off-by: Yujie Liu <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
  • Loading branch information
Yujie-Liu authored and mhiramat committed Nov 10, 2023
1 parent ce51e61 commit f032c53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/trace/trace_kprobe.c
Original file line number Diff line number Diff line change
Expand Up @@ -1020,9 +1020,9 @@ EXPORT_SYMBOL_GPL(kprobe_event_cmd_init);
/**
* __kprobe_event_gen_cmd_start - Generate a kprobe event command from arg list
* @cmd: A pointer to the dynevent_cmd struct representing the new event
* @kretprobe: Is this a return probe?
* @name: The name of the kprobe event
* @loc: The location of the kprobe event
* @kretprobe: Is this a return probe?
* @...: Variable number of arg (pairs), one pair for each field
*
* NOTE: Users normally won't want to call this function directly, but
Expand Down

0 comments on commit f032c53

Please sign in to comment.