Use existing docker secret

noroutine · Dec 15, 2023 · 06fea39 · 06fea39
1 parent 6af741b
commit 06fea39
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/helm-chart/binderhub/schema.yaml b/helm-chart/binderhub/schema.yaml
@@ -150,6 +150,21 @@ properties:
           A list of references to existing Kubernetes Secrets with credentials
           to pull the image.
 
+  dockerConfig:
+    type: object
+    additionalProperties: false
+    description: |
+      TODO
+    properties:
+      useExistingSecret:
+        type: boolean
+        description: |
+          TODO
+      secretName:
+        type: [string, "null"]
+        description: |
+          TODO
+
   registry:
     type: object
     additionalProperties: false

diff --git a/helm-chart/binderhub/templates/deployment.yaml b/helm-chart/binderhub/templates/deployment.yaml
@@ -63,7 +63,11 @@ spec:
       {{- if .Values.config.BinderHub.use_registry }}
       - name: docker-secret
         secret:
+          {{- if .Values.dockerConfig.useExistingSecret }}
+          secretName: {{ .Values.dockerConfig.secretName }}
+          {{- else }}
           secretName: {{ include "binderhub.fullname" . }}-binder-build-docker-config
+          {{- end }}
       {{- else }}
       - name: docker-socket
         hostPath:

diff --git a/helm-chart/binderhub/values.yaml b/helm-chart/binderhub/values.yaml
@@ -22,6 +22,12 @@ image:
   pullPolicy: ""
   pullSecrets: []
 
+# kubernetes secret name with docker config inside
+# use additional input parameter to stay at least partially compatible with source chart
+dockerConfig:
+  useExistingSecret: false
+  secretName: binder-precreated-docker-config
+
 # registry here is only used to create docker config.json
 registry:
   # key in 'auths' in docker config.json,