Skip to content

Commit

Permalink
Merge pull request jupyterhub#386 from jupyterhub/revert-380-revert-3…
Browse files Browse the repository at this point in the history
…78-r2d-usernames

Revert "Revert "Add user-name and user-id arguments to build command""
  • Loading branch information
yuvipanda authored Jan 2, 2018
2 parents d3f7209 + f110d6b commit 5283f6b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion binderhub/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def _add_slash(self, proposal):
)

builder_image_spec = Unicode(
'jupyter/repo2docker:v0.4.1',
'jupyter/repo2docker:235f0ad',
help="""
The builder image to be used for doing builds
""",
Expand Down
2 changes: 2 additions & 0 deletions binderhub/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ def get_cmd(self):
'--ref', self.ref,
'--image', self.image_name,
'--no-clean', '--no-run', '--json-logs',
'--user-name', 'jovyan',
'--user-id', '1000'
]

if self.push_secret:
Expand Down
2 changes: 1 addition & 1 deletion helm-chart/binderhub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ image:
name: jupyterhub/k8s-binderhub
tag: local

repo2dockerImage: jupyter/repo2docker:v0.4.1
repo2dockerImage: jupyter/repo2docker:235f0ad

googleAnalyticsCode:

Expand Down

0 comments on commit 5283f6b

Please sign in to comment.