Skip to content

Commit

Permalink
switch default server to jupyter-server-based jupyter-lab
Browse files Browse the repository at this point in the history
This will launch jupyter-server, and be far more likely to be compatible with current repos
than launching the old jupyter-notebook server
  • Loading branch information
minrk committed Feb 15, 2023
1 parent c71a203 commit 68e093f
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions helm-chart/binderhub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,14 @@ jupyterhub:
else:
have_lab = major >= 3
if have_lab and "NotebookApp.default_url" not in " ".join(sys.argv):
# if recent-enough lab is available, make it the default UI
sys.argv.insert(1, "--NotebookApp.default_url=/lab/")
if have_lab:
# technically, we could accept another jupyter-server-based frontend
exe = "jupyter-lab"
else:
exe = "jupyter-notebook"
# launch the notebook server
os.execvp("jupyter-notebook", sys.argv)
os.execvp(exe, sys.argv)
events: true
storage:
type: none
Expand Down

0 comments on commit 68e093f

Please sign in to comment.