Fix issue in stb_tilemap_editor.h which caused tiles in palette to be rendered incorrectly #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that fix is correct, you don't want to send back the internal slot number. It's only working because you're assigning IDs from 0..n-1 which matches the internal slot number. I think the correct value is t->id, but I haven't tested. |
… rendered incorrectly
|
ah right thanks, I've updated it to use |
|
Thanks for this fix, saved me from debugging it myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
STBTE__IDwas used instead of the ID, so an incorrect ID was passed to theSTBTE_DRAW_TILEfunction.