stb_vorbis: report the sample-accurate offset #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `stb_vorbis_get_playback_sample_offset()` call that reports the sample-accurate position which is required for several operations such as loop range processing.
sezero
added a commit
to libsdl-org/SDL_mixer
that referenced
this pull request
May 21, 2022
- Keeps the original stb_vorbis as intact as possible so that future updates from mainstream would be painless. - Reduces STB_VORBIS_MAX_CHANNELS from 16 to 6 (objections?) - Adds several missing libm function overrides, - SDL_mixer now requires SDL >= 2.0.9 because of SDL_exp() - Fixes slow loads and leaks in start_decoder: nothings/stb#1174 - Fixes submap array out-of-bounds indexing bug: nothings/stb#1312 - Replace signed overflow clamps with unsigned overflow: nothings/stb#1168 - Replaces alloca() usage with setup_malloc() (from libxmp.) - Fixes '-Wmaybe-uninitialized' warnings in get_seek_page_info: nothings/stb#1172 - A minor UBSan fix and suppression: nothings/stb#1168 - Fixes signature of dummy realloc() for STB_VORBIS_NO_CRT: nothings/stb#1198 - Renames BUFFER_SIZE macro to STB_BUFFER_SIZE: nothings/stb#1078 - Pulls in sample-accurate offset patch of Vitaly Novichkov: (stb_vorbis_get_playback_sample_offset, because it's used in OGG_Tell and OGG_GetSome): nothings/stb#1294 nothings/stb#1295 - Fixes a few warnings here and there in some environments. - Replaces two dummy '(void) 0' with 'do {} while(0)'
sezero
added a commit
to libsdl-org/SDL_mixer
that referenced
this pull request
May 21, 2022
- Keeps the original stb_vorbis as intact as possible so that future updates from mainstream would be painless. - Reduces STB_VORBIS_MAX_CHANNELS from 16 to 6 (objections?) - Adds several missing libm function overrides, - SDL_mixer now requires SDL >= 2.0.9 because of SDL_exp() - Fixes slow loads and leaks in start_decoder: nothings/stb#1174 - Fixes submap array out-of-bounds indexing bug: nothings/stb#1312 - Replace signed overflow clamps with unsigned overflow: nothings/stb#1168 - Replaces alloca() usage with setup_malloc() (from libxmp.) - Fixes '-Wmaybe-uninitialized' warnings in get_seek_page_info: nothings/stb#1172 - A minor UBSan fix and suppression: nothings/stb#1168 - Fixes signature of dummy realloc() for STB_VORBIS_NO_CRT: nothings/stb#1198 - Renames BUFFER_SIZE macro to STB_BUFFER_SIZE: nothings/stb#1078 - Pulls in sample-accurate offset patch of Vitaly Novichkov: (stb_vorbis_get_playback_sample_offset, because it's used in OGG_Tell and OGG_GetSome): nothings/stb#1294 nothings/stb#1295 - Fixes a few warnings here and there in some environments. - Replaces two dummy '(void) 0' with 'do {} while(0)'
This was referenced May 23, 2022
sezero
pushed a commit
to sezero/stb
that referenced
this pull request
Dec 12, 2023
Added the `stb_vorbis_get_playback_sample_offset()` call that reports the sample-accurate position which is required for several operations such as loop range processing. nothings#1295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
stb_vorbis_get_playback_sample_offset()call that reports the sample-accurate position which is required for several operations such as loop range processing.Fixes #1294