stb_image: Fix "unused invalid_chunk" with STBI_FAILURE_USERMSG #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If STBI_FAILURE_USERMSG is set, GCC warns:
stb_image.h:5183:28: warning: variable ‘invalid_chunk’ set but not
used [-Wunused-but-set-variable]
static char invalid_chunk[] = "XXXX PNG chunk not known";
Add STBI_FAILURE_USERMSG to the ifndef condition that disables the
section (along with STBI_NO_FAILURE_STRINGS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
STBI_FAILURE_USERMSGis set, GCC warns:Add STBI_FAILURE_USERMSG to the ifndef condition that disables the section (along with STBI_NO_FAILURE_STRINGS).
Note: I don't need (and weakly don't want) to be added to the contributor's list. I don't care about attribution.