stb_image_write: Fix error caused by use of sprintf on MSVC #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__STDC_LIB_EXT1__ is not defined on MSVC, causing line 766 to raise the following error: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
Prevents some warnings
Not sure if this is wanted, but this will use the _s variants of functions where supported (C11)
neondev1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__STDC_LIB_EXT1__is not defined on MSVC, causing line 766 to raise the following error:I initially replaced the condition with
defined(_MSC_VER) && _MSC_VER >= 1400for the sake of consistency with the other two occurrences of_sfunctions in this file, but I later (in the third commit) replaced the conditions with(defined(__STDC_WANT_LIB_EXT1__) && __STDC_WANT_LIB_EXT1__ && defined(__STDC_LIB_EXT1__)) || (defined(_MSC_VER) && _MSC_VER >= 1400)for all three locations where_sfunctions were called so that_sfunctions would be used over regular functions where supported; if the latter is unwanted, please feel free to remove it. A call tosnprintfwas also added for non-MSVC implementations supporting C99 but not_sfunctions.The updated code compiles using GCC and MSVC on Windows as well as GCC and Clang on Ubuntu.