virtio-rng: add check of period

If period is assigned to 0, limit timer will expire immediately. It causes a qemu warning: "main-loop: WARNING: I/O thread spun for 1000 iterations" This limit is meaningless. This patch forbids to assign 0 to period. Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amos Kong <[email protected]> Message-id: [email protected] Signed-off-by: Anthony Liguori <[email protected]>
npe9 · Nov 21, 2013 · d44bb86 · d44bb86
1 parent 376827d
commit d44bb86
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
@@ -139,6 +139,12 @@ static int virtio_rng_device_init(VirtIODevice *vdev)
     VirtIORNG *vrng = VIRTIO_RNG(vdev);
     Error *local_err = NULL;
 
+    if (!vrng->conf.period_ms > 0) {
+        qerror_report(QERR_INVALID_PARAMETER_VALUE, "period",
+                      "a positive number");
+        return -1;
+    }
+
     if (vrng->conf.rng == NULL) {
         vrng->conf.default_backend = RNG_RANDOM(object_new(TYPE_RNG_RANDOM));