Skip to content

Commit

Permalink
Replaced ngx_conf_full_name() with ngx_get_full_name().
Browse files Browse the repository at this point in the history
The ngx_get_full_name() function takes more readable arguments list.
  • Loading branch information
VBart committed Aug 6, 2013
1 parent 3c5bd34 commit d29d21b
Show file tree
Hide file tree
Showing 12 changed files with 45 additions and 22 deletions.
10 changes: 7 additions & 3 deletions src/core/nginx.c
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,9 @@ ngx_process_options(ngx_cycle_t *cycle)
ngx_str_set(&cycle->conf_file, NGX_CONF_PATH);
}

if (ngx_conf_full_name(cycle, &cycle->conf_file, 0) != NGX_OK) {
if (ngx_get_full_name(cycle->pool, &cycle->prefix, &cycle->conf_file)
!= NGX_OK)
{
return NGX_ERROR;
}

Expand Down Expand Up @@ -1013,7 +1015,7 @@ ngx_core_module_init_conf(ngx_cycle_t *cycle, void *conf)
ngx_str_set(&ccf->pid, NGX_PID_PATH);
}

if (ngx_conf_full_name(cycle, &ccf->pid, 0) != NGX_OK) {
if (ngx_get_full_name(cycle->pool, &cycle->prefix, &ccf->pid) != NGX_OK) {
return NGX_CONF_ERROR;
}

Expand Down Expand Up @@ -1061,7 +1063,9 @@ ngx_core_module_init_conf(ngx_cycle_t *cycle, void *conf)
ngx_str_set(&ccf->lock_file, NGX_LOCK_PATH);
}

if (ngx_conf_full_name(cycle, &ccf->lock_file, 0) != NGX_OK) {
if (ngx_get_full_name(cycle->pool, &cycle->prefix, &ccf->lock_file)
!= NGX_OK)
{
return NGX_CONF_ERROR;
}

Expand Down
4 changes: 2 additions & 2 deletions src/core/ngx_conf_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ ngx_conf_include(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)

ngx_log_debug1(NGX_LOG_DEBUG_CORE, cf->log, 0, "include %s", file.data);

if (ngx_conf_full_name(cf->cycle, &file, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, &file) != NGX_OK) {
return NGX_CONF_ERROR;
}

Expand Down Expand Up @@ -822,7 +822,7 @@ ngx_conf_open_file(ngx_cycle_t *cycle, ngx_str_t *name)
if (name->len) {
full = *name;

if (ngx_conf_full_name(cycle, &full, 0) != NGX_OK) {
if (ngx_get_full_name(cycle->pool, &cycle->prefix, &full) != NGX_OK) {
return NULL;
}

Expand Down
8 changes: 6 additions & 2 deletions src/core/ngx_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,9 @@ ngx_conf_set_path_slot(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
path->name.len--;
}

if (ngx_conf_full_name(cf->cycle, &path->name, 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &path->name)
!= NGX_OK)
{
return NULL;
}

Expand Down Expand Up @@ -409,7 +411,9 @@ ngx_conf_merge_path_value(ngx_conf_t *cf, ngx_path_t **path, ngx_path_t *prev,

(*path)->name = init->name;

if (ngx_conf_full_name(cf->cycle, &(*path)->name, 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &(*path)->name)
!= NGX_OK)
{
return NGX_CONF_ERROR;
}

Expand Down
12 changes: 6 additions & 6 deletions src/event/ngx_event_openssl.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ ngx_ssl_certificate(ngx_conf_t *cf, ngx_ssl_t *ssl, ngx_str_t *cert,
X509 *x509;
u_long n;

if (ngx_conf_full_name(cf->cycle, cert, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, cert) != NGX_OK) {
return NGX_ERROR;
}

Expand Down Expand Up @@ -319,7 +319,7 @@ ngx_ssl_certificate(ngx_conf_t *cf, ngx_ssl_t *ssl, ngx_str_t *cert,

BIO_free(bio);

if (ngx_conf_full_name(cf->cycle, key, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, key) != NGX_OK) {
return NGX_ERROR;
}

Expand Down Expand Up @@ -350,7 +350,7 @@ ngx_ssl_client_certificate(ngx_conf_t *cf, ngx_ssl_t *ssl, ngx_str_t *cert,
return NGX_OK;
}

if (ngx_conf_full_name(cf->cycle, cert, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, cert) != NGX_OK) {
return NGX_ERROR;
}

Expand Down Expand Up @@ -394,7 +394,7 @@ ngx_ssl_trusted_certificate(ngx_conf_t *cf, ngx_ssl_t *ssl, ngx_str_t *cert,
return NGX_OK;
}

if (ngx_conf_full_name(cf->cycle, cert, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, cert) != NGX_OK) {
return NGX_ERROR;
}

Expand All @@ -421,7 +421,7 @@ ngx_ssl_crl(ngx_conf_t *cf, ngx_ssl_t *ssl, ngx_str_t *crl)
return NGX_OK;
}

if (ngx_conf_full_name(cf->cycle, crl, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, crl) != NGX_OK) {
return NGX_ERROR;
}

Expand Down Expand Up @@ -587,7 +587,7 @@ ngx_ssl_dhparam(ngx_conf_t *cf, ngx_ssl_t *ssl, ngx_str_t *file)
return NGX_OK;
}

if (ngx_conf_full_name(cf->cycle, file, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, file) != NGX_OK) {
return NGX_ERROR;
}

Expand Down
2 changes: 1 addition & 1 deletion src/event/ngx_event_openssl_stapling.c
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ ngx_ssl_stapling_file(ngx_conf_t *cf, ngx_ssl_t *ssl, ngx_str_t *file)

staple = SSL_CTX_get_ex_data(ssl->ctx, ngx_ssl_stapling_index);

if (ngx_conf_full_name(cf->cycle, file, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, file) != NGX_OK) {
return NGX_ERROR;
}

Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_geo_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1327,7 +1327,7 @@ ngx_http_geo_include(ngx_conf_t *cf, ngx_http_geo_conf_ctx_t *ctx,

ngx_sprintf(file.data, "%V.bin%Z", name);

if (ngx_conf_full_name(cf->cycle, &file, 1) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->conf_prefix, &file) != NGX_OK) {
return NGX_CONF_ERROR;
}

Expand Down
4 changes: 3 additions & 1 deletion src/http/modules/ngx_http_log_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1134,7 +1134,9 @@ ngx_http_log_set_log(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
}

} else {
if (ngx_conf_full_name(cf->cycle, &value[1], 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &value[1])
!= NGX_OK)
{
return NGX_CONF_ERROR;
}

Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_xslt_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ ngx_http_xslt_stylesheet(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)

ngx_memzero(sheet, sizeof(ngx_http_xslt_sheet_t));

if (ngx_conf_full_name(cf->cycle, &value[1], 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &value[1]) != NGX_OK) {
return NGX_CONF_ERROR;
}

Expand Down
4 changes: 3 additions & 1 deletion src/http/modules/perl/ngx_http_perl_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,9 @@ ngx_http_perl_init_interpreter(ngx_conf_t *cf, ngx_http_perl_main_conf_t *pmcf)
if (pmcf->modules != NGX_CONF_UNSET_PTR) {
m = pmcf->modules->elts;
for (i = 0; i < pmcf->modules->nelts; i++) {
if (ngx_conf_full_name(cf->cycle, &m[i], 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &m[i])
!= NGX_OK)
{
return NGX_CONF_ERROR;
}
}
Expand Down
8 changes: 6 additions & 2 deletions src/http/ngx_http_core_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -3686,7 +3686,9 @@ ngx_http_core_merge_loc_conf(ngx_conf_t *cf, void *parent, void *child)
if (prev->root.data == NULL) {
ngx_str_set(&conf->root, "html");

if (ngx_conf_full_name(cf->cycle, &conf->root, 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &conf->root)
!= NGX_OK)
{
return NGX_CONF_ERROR;
}
}
Expand Down Expand Up @@ -4428,7 +4430,9 @@ ngx_http_core_root(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
}

if (clcf->root.data[0] != '$') {
if (ngx_conf_full_name(cf->cycle, &clcf->root, 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &clcf->root)
!= NGX_OK)
{
return NGX_CONF_ERROR;
}
}
Expand Down
4 changes: 3 additions & 1 deletion src/http/ngx_http_file_cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -1626,7 +1626,9 @@ ngx_http_file_cache_set_slot(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
cache->path->name.len--;
}

if (ngx_conf_full_name(cf->cycle, &cache->path->name, 0) != NGX_OK) {
if (ngx_get_full_name(cf->pool, &cf->cycle->prefix, &cache->path->name)
!= NGX_OK)
{
return NGX_CONF_ERROR;
}

Expand Down
7 changes: 6 additions & 1 deletion src/http/ngx_http_script.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,12 @@ ngx_http_compile_complex_value(ngx_http_compile_complex_value_t *ccv)
if ((v->len == 0 || v->data[0] != '$')
&& (ccv->conf_prefix || ccv->root_prefix))
{
if (ngx_conf_full_name(ccv->cf->cycle, v, ccv->conf_prefix) != NGX_OK) {
if (ngx_get_full_name(ccv->cf->pool,
ccv->conf_prefix ? &ccv->cf->cycle->conf_prefix:
&ccv->cf->cycle->prefix,
v)
!= NGX_OK)
{
return NGX_ERROR;
}

Expand Down

0 comments on commit d29d21b

Please sign in to comment.