collectd: snmp6 further improvements

Return with "-1" if parsing fails in read function. Reduce buffersize of splitstring function. Signed-off-by: Nick Hainke <[email protected]>
npmmirror · Jan 26, 2021 · 213c694 · 213c694
1 parent 922e5b1
commit 213c694
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/utils/collectd/patches/931-snmp6-add-ipv6-statistics.patch b/utils/collectd/patches/931-snmp6-add-ipv6-statistics.patch
@@ -155,7 +155,7 @@ Signed-off-by: Nick Hainke <[email protected]>
 +int snmp_read(char *ifname) {
 +  FILE *fh;
 +  char buffer[1024];
-+  char *fields[16];
++  char *fields[2];
 +  int numfields;
 +  int currline = 0;
 +  derive_t data[76];
@@ -178,17 +178,17 @@ Signed-off-by: Nick Hainke <[email protected]>
 +  }
 +
 +  while (fgets(buffer, 1024, fh) != NULL) {
-+    numfields = strsplit(buffer, fields, 16);
++    numfields = strsplit(buffer, fields, 2);
 +
 +    if (numfields < 2)
-+      continue;
++      return -1;
 +
 +    data[currline++] = atoll(fields[1]);
 +  }
 +
 +  fclose(fh);
 +
-+  if (currline < 25) {
++  if (currline < 28) {
 +    return -1;
 +  }
 +