fix misused-promise weirdness with eslint rule

nramkissoon · Mar 9, 2023 · 5121a63 · 5121a63
1 parent 62ccf96
commit 5121a63
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 16 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -18,6 +18,11 @@ const config = {
   plugins: ["@typescript-eslint"],
   extends: ["next/core-web-vitals", "plugin:@typescript-eslint/recommended"],
   rules: {
+    "@typescript-eslint/no-misused-promises": [2, {
+      "checksVoidReturn": {
+        "attributes": false
+      }
+    }],
     "@typescript-eslint/consistent-type-imports": [
       "warn",
       {

diff --git a/src/pages/dashboard.tsx b/src/pages/dashboard.tsx
@@ -26,14 +26,12 @@ const UpgradeButton = () => {
   return (
     <button
       className="w-fit cursor-pointer rounded-md bg-blue-500 px-5 py-2 text-lg font-semibold text-white shadow-sm duration-150 hover:bg-blue-600"
-      onClick={() =>
-        void (async () => {
-          const { checkoutUrl } = await createCheckoutSession();
-          if (checkoutUrl) {
-            void push(checkoutUrl);
-          }
-        })
-      }
+      onClick={async () => {
+        const { checkoutUrl } = await createCheckoutSession();
+        if (checkoutUrl) {
+          void push(checkoutUrl);
+        }
+      }}
     >
       Upgrade account
     </button>
@@ -47,14 +45,12 @@ const ManageBillingButton = () => {
   return (
     <button
       className="w-fit cursor-pointer rounded-md bg-blue-500 px-5 py-2 text-lg font-semibold text-white shadow-sm duration-150 hover:bg-blue-600"
-      onClick={() =>
-        void (async () => {
-          const { billingPortalUrl } = await createBillingPortalSession();
-          if (billingPortalUrl) {
-            void push(billingPortalUrl);
-          }
-        })
-      }
+      onClick={async () => {
+        const { billingPortalUrl } = await createBillingPortalSession();
+        if (billingPortalUrl) {
+          void push(billingPortalUrl);
+        }
+      }}
     >
       Manage subscription and billing
     </button>