feat(core): support bun's new text-based lockfile and use bun publish within nx release #30064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
requested review from
a team,
meeroslav,
vsavkin and
mandarini
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit a473fa2.
☁️ Nx Cloud last updated this comment at |
JamesHenry
changed the title
JamesHenry
force-pushed
the
more-support-for-publishing-workspace-protocol
branch
from
8575c37 to
c0bbebe
Compare
JamesHenry
requested review from
a team,
FrozenPandaz,
AgentEnder and
jaysoo
as code owners
JamesHenry
force-pushed
the
more-support-for-publishing-workspace-protocol
branch
from
dfc9d63 to
79a945b
Compare
4 tasks
JamesHenry
force-pushed
the
more-support-for-publishing-workspace-protocol
branch
from
da309d2 to
578c00f
Compare
|
This also should fix #29429 |
|
@matthewrj Just the bun-specific manifestation, we will add better handling for the missing lockfile case in general to properly address that one |
JamesHenry
force-pushed
the
more-support-for-publishing-workspace-protocol
branch
from
fcba099 to
d9414c6
Compare
JamesHenry
force-pushed
the
more-support-for-publishing-workspace-protocol
branch
from
bbcfb20 to
9a6795b
Compare
JamesHenry
force-pushed
the
more-support-for-publishing-workspace-protocol
branch
from
9a6795b to
b257fcd
Compare
… within nx release
JamesHenry
force-pushed
the
more-support-for-publishing-workspace-protocol
branch
from
96a226d to
9264f0c
Compare
isaacplmann
approved these changes
Feb 18, 2025
jaysoo
reviewed
Feb 18, 2025
packages/expo/src/generators/application/lib/create-application-files.ts
Outdated
Show resolved
Hide resolved
JamesHenry
deleted the
more-support-for-publishing-workspace-protocol
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
1.2) text-based lockfile is not picked up by Nxpnpmfor dynamically replacing local dependency protocols at publish time.Expected Behavior
Bun's text-based
bun.lockis picked up by NxWe support both
pnpmandbunfor dynamically replacing local dependency protocols at publish time, and include more specific messaging for why modernyarnis not (hopefully "yet") supported.Also resolves the package manager detection logic by folding in #28546
Related Issue(s)
Fixes #28201
FIxes #29422
Fixes #29494