Skip to content

Commit

Permalink
Maintenance: Apply source string review changes.
Browse files Browse the repository at this point in the history
  • Loading branch information
mgruner committed Dec 15, 2021
1 parent 80e76fc commit 0ccdfb3
Show file tree
Hide file tree
Showing 81 changed files with 241 additions and 234 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class ChannelChat extends App.ControllerSubContent
name: 'fontSize'
default: 'undefined'
type: 'String'
description: __('CSS font-size with a unit like 12px, 1.5em. If left to undefined it inherits the font-size of the website.')
description: __('CSS font-size with a unit like 12px, 1.5em. If left undefined it inherits the font-size of the website.')
}
{
name: 'flat'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class ChannelAccountOverview extends App.ControllerSubContent
error: (data) =>
@notify
type: 'error'
msg: __('Failed to rollback migration of the channel!')
msg: __('Failed to roll back the migration of the channel!')
)

groupChange: (e) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ class ChannelAccountOverview extends App.ControllerSubContent
error: (data) =>
@notify
type: 'error'
msg: __('Failed to rollback migration of the channel!')
msg: __('Failed to roll back the migration of the channel!')
)

groupChange: (e) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ App.Config.set(
{
name: __('Checkmk')
target: '#system/integration/check_mk'
description: __('An open source monitoring tool.')
description: __('An open-source monitoring tool.')
controller: CheckMk
state: State
permission: ['admin.integration.check_mk']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Cti extends App.ControllerIntegrationBase
featureConfig: 'cti_config'
description: [
[__('This service shows you contacts of incoming calls and a caller list in realtime.')]
[__('Also caller id of outbound calls can be changed.')]
[__('Caller ID of outbound calls can be changed as well.')]
]
events:
'click .js-select': 'selectAll'
Expand Down Expand Up @@ -135,7 +135,7 @@ class Form extends App.Controller
}
)

# blocked caller ids
# blocked caller IDs
config.inbound.block_caller_ids = []
@$('.js-inboundBlockCallerId .js-row').each(->
caller_id = $(@).find('input[name="caller_id"]').val()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ App.Config.set(
{
name: __('Icinga')
target: '#system/integration/icinga'
description: __('An open source monitoring tool.')
description: __('An open-source monitoring tool.')
controller: Icinga
state: State
permission: ['admin.integration.icinga']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ App.Config.set(
{
name: __('Monit')
target: '#system/integration/monit'
description: __('An open source monitoring tool.')
description: __('An open-source monitoring tool.')
controller: Monit
state: State
permission: ['admin.integration.monit']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ App.Config.set(
{
name: __('Nagios')
target: '#system/integration/nagios'
description: __('An open source monitoring tool.')
description: __('An open-source monitoring tool.')
controller: Nagios
state: State
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Placetel extends App.ControllerIntegrationBase
featureConfig: 'placetel_config'
description: [
[__('This service shows you contacts of incoming calls and a caller list in realtime.')]
[__('Also caller id of outbound calls can be changed.')]
[__('Caller ID of outbound calls can be changed as well.')]
]
events:
'click .js-select': 'selectAll'
Expand Down Expand Up @@ -111,7 +111,7 @@ class Form extends App.Controller
}
)

# blocked caller ids
# blocked caller IDs
config.inbound.block_caller_ids = []
@$('.js-inboundBlockCallerId .js-row').each(->
caller_id = $(@).find('input[name="caller_id"]').val()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class SipgateIo extends App.ControllerIntegrationBase
featureConfig: 'sipgate_config'
description: [
[__('This service shows you contacts of incoming calls and a caller list in realtime.')]
[__('Also caller id of outbound calls can be changed.')]
[__('Caller ID of outbound calls can be changed as well.')]
]
events:
'click .js-select': 'selectAll'
Expand Down Expand Up @@ -108,7 +108,7 @@ class Form extends App.Controller
}
)

# blocked caller ids
# blocked caller IDs
config.inbound.block_caller_ids = []
@$('.js-inboundBlockCallerId .js-row').each(->
caller_id = $(@).find('input[name="caller_id"]').val()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class App.SettingTicketAutoAssignment extends App.ControllerSubContent
@html(App.view('settings/ticket_auto_assignment')())

configure_attributes = [
{ name: 'condition', display: __('Conditions for effected objects'), tag: 'ticket_selector', null: false, preview: false, action: false, hasChanged: false, article: false },
{ name: 'condition', display: __('Conditions for affected objects'), tag: 'ticket_selector', null: false, preview: false, action: false, hasChanged: false, article: false },
]

ticket_auto_assignment_selector = App.Setting.get('ticket_auto_assignment_selector')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class SessionTimeout extends App.Controller

@warningDialog = new App.ControllerModal(
head: __('Session')
message: __('Due to inactivity are automatically logged out within the next 30 seconds.')
message: __('Due to inactivity, you will be automatically logged out within the next 30 seconds.')
keyboard: true
backdrop: true
buttonClose: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class ProfilePassword extends App.ControllerSubContent
@$('[name=password_new_confirm]').val('')
@notify
type: 'error'
msg: __('Can\'t update password, your new passwords do not match. Please try again!')
msg: __('Can\'t update password, your entered passwords do not match. Please try again!')
removeAll: true
return
if !params['password_new']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class App.UiElement.holiday_selector
# check if entry already exists
exists = item.find("[data-date=#{date}]").get(0)
if exists
alert(App.i18n.translateInline('Aready exists!'))
alert(App.i18n.translateInline('This entry already exists!'))
return

# reset form input
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ class App.UiElement.object_manager_attribute extends App.UiElement.ApplicationUi
params: params
)
configureAttributes = [
{ name: 'data_option::diff', display: __('Default time Diff (minutes)'), tag: 'integer', null: true },
{ name: 'data_option::diff', display: __('Default time diff (minutes)'), tag: 'integer', null: true },
]
datetimeDiff = new App.ControllerForm(
model:
Expand All @@ -258,7 +258,7 @@ class App.UiElement.object_manager_attribute extends App.UiElement.ApplicationUi

@date: (item, localParams, params) ->
configureAttributes = [
{ name: 'data_option::diff', display: __('Default time Diff (hours)'), tag: 'integer', null: true },
{ name: 'data_option::diff', display: __('Default time diff (hours)'), tag: 'integer', null: true },
]
dateDiff = new App.ControllerForm(
model:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ class App.UiElement.postmaster_match
},
{
value: 'cc'
name: __('Cc')
name: __('CC')
},
{
value: 'x-any-recipient'
name: __('Any Recipient')
name: __('Any recipient')
},
{
value: 'subject'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,10 +362,10 @@ class App.UiElement.ticket_perform_action
elementRow.find('.js-setNotification').empty()

options =
'article_last_sender': __('Article Last Sender')
'article_last_sender': __('Sender of last article')
'ticket_owner': __('Owner')
'ticket_customer': __('Customer')
'ticket_agents': __('All Agents')
'ticket_agents': __('All agents')

name = "#{attribute.name}::notification.#{notificationType}"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ class App.UiElement.timezone extends App.UiElement.ApplicationUiElement
@selectedOptions(attribute, params)

attribute.tag = 'searchable_select'
attribute.placeholder = App.i18n.translateInline('Enter timezone...')
attribute.placeholder = App.i18n.translateInline('Enter time zone')
App.UiElement.searchable_select.render(attribute)
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class App.TicketCreate extends App.Controller

App.Ticket.configure_attributes.push {
name: 'cc'
display: __('Cc')
display: __('CC')
tag: 'input'
type: 'text'
maxlength: 1000
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/controllers/chat.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ class App.CustomerChat extends App.Controller
@switch(false)
@notify(
type: 'notice'
msg: App.i18n.translateContent('Chat not answered, set to offline automatically.')
msg: App.i18n.translateContent('Chat not answered, automatically set to offline.')
)
@idleTimeoutId = @delay(switchOff, @idleTimeout * 1000)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class App.KnowledgeBaseContentController extends App.Controller
@rerenderIfConfirmed()

rerenderIfConfirmed: ->
text = App.i18n.translatePlain('Changes were made. Do you want to reload? You\'ll loose your changes')
text = App.i18n.translatePlain('Are you sure you want to reload? You have unsaved changes that will get lost')
if confirm(text)
@render()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class App.KnowledgeBaseSidebarAttachments extends App.Controller

class DeleteConfirm extends App.ControllerConfirm
content: ->
sentence = App.i18n.translateContent('Are you sure to delete')
sentence = App.i18n.translateContent('Are you sure you want to delete')
"#{sentence} #{@attachment.filename}?"
buttonSubmit: __('delete')
onSubmit: ->
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/controllers/login.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Login extends App.ControllerFullPage
data = {}
if window.location.hash is '#session_timeout'
data = {
errorMessage: App.i18n.translateContent('Due to inactivity you are automatically logged out.')
errorMessage: App.i18n.translateContent('Due to inactivity, you have been automatically logged out.')
}

@title __('Sign in')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class PasswordResetVerify extends App.ControllerFullPage
@$('[name=password_confirm]').val('')
@notify(
type: 'error'
msg: __('Can\'t update password, your new passwords do not match. Please try again!')
msg: __('Can\'t update password, your entered passwords do not match. Please try again!')
removeAll: true
)
return
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ class ArticleViewItem extends App.ControllerObserver
if data.encryption.success
@notify
type: 'success'
msg: App.i18n.translateContent('Decryption success!')
msg: App.i18n.translateContent('Decryption successful!')
else if data.encryption.comment
comment = App.i18n.translateContent('Decryption failed!') + ' ' + App.i18n.translateContent(data.encryption.comment || '')
@notify
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class TimeAccounting extends App.ControllerSubContent
)

configure_attributes = [
{ name: 'condition', display: __('Conditions for effected objects'), tag: 'ticket_selector', null: false, preview: false, action: false, hasChanged: false },
{ name: 'condition', display: __('Conditions for affected objects'), tag: 'ticket_selector', null: false, preview: false, action: false, hasChanged: false },
]

filter_params = App.Setting.get('time_accounting_selector')
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/controllers/user_profile.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class ActionRow extends App.ControllerObserverActionRow
error: (data, status, xhr) =>
@notify
type: 'error'
msg: App.i18n.translateContent('Failed to sent Email "%s". Please contact an administrator.', user.email)
msg: App.i18n.translateContent('Failed to send email to "%s". Please contact an administrator.', user.email)
removeAll: true
)

Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/lib/base/word_filter.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ window.word_filter = function(editor){
}
})

// style and align is handled by utils.coffee it self, don't clean it here
// style and align is handled by utils.coffee itself, don't clean it here
//$('[style]', editor).removeAttr('style');
//$('[align]', editor).removeAttr('align');
$('span', editor).replaceWith(function() {return $(this).contents();});
Expand Down
4 changes: 2 additions & 2 deletions app/assets/javascripts/app/models/_application_model.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ set new attributes of model (remove already available attributes)
},
'assignment_timeout': {
name: 'assignment_timeout'
display: __('Assignment Timeout')
display: __('Assignment timeout')
tag: 'input'
type: 'text'
limit: 100
Expand Down Expand Up @@ -696,7 +696,7 @@ set new attributes of model (remove already available attributes)
# lookup relations
if attribute.relation

# relations - not calling object it self, to prevent loops
# relations - not calling object itself, to prevent loops
if !_.contains(classNames, @className)

# only if relation model exists
Expand Down
4 changes: 2 additions & 2 deletions app/assets/javascripts/app/models/group.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ class App.Group extends App.Model

@configure_attributes = [
{ name: 'name', display: __('Name'), tag: 'input', type: 'text', limit: 100, null: false },
{ name: 'assignment_timeout', display: __('Assignment Timeout'), tag: 'input', note: __('Assignment timeout in minutes if assigned agent is not working on it. Ticket will be shown as unassigend.'), type: 'text', limit: 100, null: true },
{ name: 'assignment_timeout', display: __('Assignment timeout'), tag: 'input', note: __('Assignment timeout in minutes if assigned agent is not working on it. Ticket will be shown as unassigend.'), type: 'text', limit: 100, null: true },
{ name: 'follow_up_possible', display: __('Follow-up possible'),tag: 'select', default: 'yes', options: { yes: 'yes', 'new_ticket': 'do not reopen Ticket but create new Ticket' }, null: false, note: __('Follow-up for closed ticket possible or not.'), translate: true },
{ name: 'follow_up_assignment', display: __('Assign Follow-Ups'), tag: 'select', default: 'yes', options: { true: 'yes', false: 'no' }, null: false, note: __('Assign follow-up to latest agent again.'), translate: true },
{ name: 'follow_up_assignment', display: __('Assign follow-ups'), tag: 'select', default: 'yes', options: { true: 'yes', false: 'no' }, null: false, note: __('Assign follow-up to latest agent again.'), translate: true },
{ name: 'email_address_id', display: __('Email'), tag: 'select', multiple: false, null: true, relation: 'EmailAddress', nulloption: true, do_not_log: true },
{ name: 'signature_id', display: __('Signature'), tag: 'select', multiple: false, null: true, relation: 'Signature', nulloption: true, do_not_log: true },
{ name: 'note', display: __('Note'), tag: 'textarea', note: __('Notes are visible to agents only, never to customers.'), limit: 250, null: true },
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/models/job.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class App.Job extends App.Model
@configure_attributes = [
{ name: 'name', display: __('Name'), tag: 'input', type: 'text', limit: 100, null: false },
{ name: 'timeplan', display: __('When should the job run?'), tag: 'timer', null: true },
{ name: 'condition', display: __('Conditions for effected objects'), tag: 'ticket_selector', null: true, executionTime: true, noCurrentUser: true },
{ name: 'condition', display: __('Conditions for affected objects'), tag: 'ticket_selector', null: true, executionTime: true, noCurrentUser: true },
{ name: 'perform', display: __('Execute changes on objects'), tag: 'ticket_perform_action', null: true, notification: true, ticket_delete: true },
{ name: 'disable_notification', display: __('Disable Notifications'), tag: 'boolean', default: true },
{ name: 'note', display: __('Note'), tag: 'textarea', note: __('Notes are visible to agents only, never to customers.'), limit: 250, null: true },
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/models/knowledge_base.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class App.KnowledgeBase extends App.Model
display: __('Icon Set')
tag: 'iconset_picker'
style: 'block'
help: __('Every category in your knowledge base should be given a unique icon for maximum visual clarity. Each set below provides a wide range of icons to choose from, but beware-you can\'t mix and match different icons from different sets. Choose carefully!')
help: __('Every category in your knowledge base should be given a unique icon for maximum visual clarity. Each set below provides a wide range of icons to choose from, but beware: You can\'t mix and match different icons from different sets. Choose carefully!')
null: false
screen:
admin_style_iconset:
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/models/organization.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class App.Organization extends App.Model
@url: @apiPath + '/organizations'
@configure_attributes = [
{ name: 'name', display: __('Name'), tag: 'input', type: 'text', limit: 100, null: false, info: true },
{ name: 'shared', display: __('Shared organization'), tag: 'boolean', note: __('Customers in the organization can view each other items.'), type: 'boolean', default: true, null: false, info: false },
{ name: 'shared', display: __('Shared organization'), tag: 'boolean', note: __("Customers in the organization can view each other's items."), type: 'boolean', default: true, null: false, info: false },
{ name: 'created_by_id', display: __('Created by'), relation: 'User', readonly: 1, info: false },
{ name: 'created_at', display: __('Created at'), tag: 'datetime', readonly: 1, info: false },
{ name: 'updated_by_id', display: __('Updated by'), relation: 'User', readonly: 1, info: false },
Expand Down
17 changes: 8 additions & 9 deletions app/assets/javascripts/app/models/text_module.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -38,25 +38,24 @@ class App.TextModule extends App.Model

# coffeelint: disable=no_interpolation_in_single_quotes
@description = __('''
Create Text Modules to **spend less time writing responses**. Text Modules can include smart variables like the users name or email address.
Create Text Modules to **spend less time writing responses**. Text Modules can include smart variables like the user's name or email address.

Examples of snippets are:

* Hello Mrs. #{ticket.customer.lastname},
* Hello Mr. #{ticket.customer.lastname},
* Hello #{ticket.customer.firstname},
* My Name is #{user.firstname},
* My name is #{user.firstname},

Of course you can also use multi line snippets.
Of course, you can also use multi-line snippets.

Available objects are:
* ticket (e. g. ticket.state, ticket.group)
* ticket.customer (e. g. ticket.customer.firstname, ticket.customer.lastname)
* ticket.owner (e. g. ticket.owner.firstname, ticket.owner.lastname)
* ticket.organization (e. g. ticket.organization.name)
* user (e. g. user.firstname, user.email)
* ticket (e.g. ticket.state, ticket.group)
* ticket.customer (e.g. ticket.customer.firstname, ticket.customer.lastname)
* ticket.owner (e.g. ticket.owner.firstname, ticket.owner.lastname)
* ticket.organization (e.g. ticket.organization.name)
* user (e.g. user.firstname, user.email)

To select placeholders from a list, just enter "::".

''')
# coffeelint: enable=no_interpolation_in_single_quotes
Loading

0 comments on commit 0ccdfb3

Please sign in to comment.