Skip to content

Commit

Permalink
[fuchsia] Update flatland TODO bug numbers (flutter#31504)
Browse files Browse the repository at this point in the history
  • Loading branch information
uysalere authored Feb 17, 2022
1 parent 44f21fc commit 83db012
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 18 deletions.
6 changes: 1 addition & 5 deletions shell/platform/fuchsia/flutter/engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ void Engine::Terminate() {
void Engine::DebugWireframeSettingsChanged(bool enabled) {
FML_CHECK(shell_);

// TODO(fxbug.dev/64201): Investigate if we can add flatland wireframe code
// TODO(fxbug.dev/94000): Investigate if we can add flatland wireframe code
// for debugging.
shell_->GetTaskRunners().GetRasterTaskRunner()->PostTask([this, enabled]() {
if (external_view_embedder_) {
Expand Down Expand Up @@ -803,8 +803,6 @@ void Engine::DestroyGfxView(int64_t view_id,
GfxViewIdCallback on_view_unbound) {
FML_CHECK(shell_);

// TODO(fxbug.dev/64201): Add flatland hookup. |view_id| may be interpreted
// based on use_flatland from the initializer.
shell_->GetTaskRunners().GetRasterTaskRunner()->PostTask(
[this, view_id, on_view_unbound = std::move(on_view_unbound)]() {
FML_CHECK(external_view_embedder_);
Expand All @@ -817,8 +815,6 @@ void Engine::DestroyFlatlandView(int64_t view_id,
FlatlandViewIdCallback on_view_unbound) {
FML_CHECK(shell_);

// TODO(fxbug.dev/64201): Add flatland hookup. |view_id| may be interpreted
// based on use_flatland from the initializer.
shell_->GetTaskRunners().GetRasterTaskRunner()->PostTask(
[this, view_id, on_view_unbound = std::move(on_view_unbound)]() {
FML_CHECK(flatland_view_embedder_);
Expand Down
6 changes: 3 additions & 3 deletions shell/platform/fuchsia/flutter/flatland_connection.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void FlatlandConnection::DoPresent() {
--present_credits_;

fuchsia::ui::composition::PresentArgs present_args;
// TODO(fxbug.dev/64201): compute a better presentation time;
// TODO(fxbug.dev/94000): compute a better presentation time;
present_args.set_requested_presentation_time(0);
present_args.set_acquire_fences(std::move(acquire_fences_));
present_args.set_release_fences(std::move(previous_present_release_fences_));
Expand Down Expand Up @@ -86,7 +86,7 @@ void FlatlandConnection::AwaitVsync(FireCallbackCallback callback) {

if (threadsafe_state_.fire_callback_pending_) {
fml::TimePoint now = fml::TimePoint::Now();
// TODO(fxbug.dev/64201): Calculate correct frame times.
// TODO(fxbug.dev/94000): Calculate correct frame times.
threadsafe_state_.fire_callback_(
now, now + kDefaultFlatlandPresentationInterval);
threadsafe_state_.fire_callback_ = nullptr;
Expand Down Expand Up @@ -121,7 +121,7 @@ void FlatlandConnection::OnNextFrameBegin(
std::scoped_lock<std::mutex> lock(threadsafe_state_.mutex_);
if (threadsafe_state_.fire_callback_) {
fml::TimePoint now = fml::TimePoint::Now();
// TODO(fxbug.dev/64201): Calculate correct frame times.
// TODO(fxbug.dev/94000): Calculate correct frame times.
threadsafe_state_.fire_callback_(
now, now + kDefaultFlatlandPresentationInterval);
threadsafe_state_.fire_callback_ = nullptr;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void FlatlandExternalViewEmbedder::BeginFrame(
Reset();
frame_size_ = frame_size;

// TODO(fxbug.dev/64201): Handle device pixel ratio.
// TODO(fxbug.dev/94000): Handle device pixel ratio.

// Create the root layer.
frame_layers_.emplace(
Expand Down Expand Up @@ -188,10 +188,10 @@ void FlatlandExternalViewEmbedder::SubmitFrame(
FML_CHECK(view_mutators.total_transform ==
view_params.transformMatrix());

// TODO(fxbug.dev/64201): Handle clips.
// TODO(fxbug.dev/94000): Handle clips.

// Set transform for the viewport.
// TODO(fxbug.dev/64201): Handle scaling.
// TODO(fxbug.dev/94000): Handle scaling.
if (view_mutators.transform != viewport.mutators.transform) {
flatland_->flatland()->SetTranslation(
viewport.transform_id,
Expand All @@ -200,8 +200,8 @@ void FlatlandExternalViewEmbedder::SubmitFrame(
viewport.mutators.transform = view_mutators.transform;
}

// TODO(fxbug.dev/64201): Set HitTestBehavior.
// TODO(fxbug.dev/64201): Set opacity.
// TODO(fxbug.dev/94000): Set HitTestBehavior.
// TODO(fxbug.dev/94000): Set opacity.

// Set size
// TODO(): Set occlusion hint, and focusable.
Expand Down Expand Up @@ -347,7 +347,7 @@ void FlatlandExternalViewEmbedder::CreateView(
.viewport_id = flatland_->NextContentId()};
flatland_->flatland()->CreateTransform(new_view.transform_id);
fuchsia::ui::composition::ViewportProperties properties;
// TODO(fxbug.dev/64201): Investigate if it is possible to avoid using a
// TODO(fxbug.dev/94000): Investigate if it is possible to avoid using a
// default size by finding the size before creation.
properties.set_logical_size(
{kFlatlandDefaultViewportSize, kFlatlandDefaultViewportSize});
Expand Down Expand Up @@ -395,7 +395,7 @@ void FlatlandExternalViewEmbedder::SetViewProperties(
auto found = flatland_views_.find(view_id);
FML_CHECK(found != flatland_views_.end());

// TODO(fxbug.dev/64201): Set occlusion_hint, hit_testable and focusable.
// TODO(fxbug.dev/94000): Set occlusion_hint, hit_testable and focusable.
}

void FlatlandExternalViewEmbedder::Reset() {
Expand Down
4 changes: 2 additions & 2 deletions shell/platform/fuchsia/flutter/flatland_platform_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void FlatlandPlatformView::OnGetLayout(
view_logical_size_ = {static_cast<float>(info.logical_size().width),
static_cast<float>(info.logical_size().height)};

// TODO(fxbug.dev/64201): Set device pixel ratio.
// TODO(fxbug.dev/94000): Set device pixel ratio.
if (info.pixel_scale().width != 1 || info.pixel_scale().height != 1) {
FML_LOG(ERROR)
<< "Flutter does not currently support pixel_scale's other than 1";
Expand Down Expand Up @@ -106,7 +106,7 @@ void FlatlandPlatformView::OnGetLayout(

void FlatlandPlatformView::OnParentViewportStatus(
fuchsia::ui::composition::ParentViewportStatus status) {
// TODO(fxbug.dev/64201): Investigate if it is useful to send hidden/shown
// TODO(fxbug.dev/94000): Investigate if it is useful to send hidden/shown
// signals.
parent_viewport_status_ = status;
parent_viewport_watcher_->GetStatus(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ constexpr scenic::Color kChildBackgroundColor = {0xFF, 0x00, 0xFF,
0xFF}; // Pink
constexpr scenic::Color kChildTappedColor = {0xFF, 0xFF, 0x00, 0xFF}; // Yellow

// TODO(fxb/64201): The new flutter renderer draws overlays as a single, large
// TODO(fxb/94000): The new flutter renderer draws overlays as a single, large
// layer. Some parts of this layer are fully transparent, so we want the
// compositor to treat the layer as transparent and blend it with the contents
// below.
Expand Down

0 comments on commit 83db012

Please sign in to comment.