Skip to content

Commit

Permalink
Fix platform env variable not registering with sdk_manager (flutter#3…
Browse files Browse the repository at this point in the history
  • Loading branch information
GaryQian authored Dec 3, 2021
1 parent f488ff9 commit a284061
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ deps = {
'packages': [
{
'package': 'flutter/android/sdk/all/${{platform}}',
'version': 'version:31v2'
'version': 'version:31v5'
}
],
'condition': 'download_android_deps',
Expand Down
4 changes: 3 additions & 1 deletion tools/android_sdk/create_sdk_cipd_packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,15 @@ for platform in "${platforms[@]}"; do
echo "Creating temporary working directory for $platform: $sdk_root"
mkdir $sdk_root
mkdir $upload_dir
export REPO_OS_OVERRIDE=$platform

# Download all the packages with sdkmanager.
for package in $(cat $package_file_name); do
echo $package
split=(${package//:/ })
echo "Installing ${split[0]}"
REPO_OS_OVERRIDE=$platform yes "y" | $sdkmanager_path --sdk_root=$sdk_root ${split[0]}
yes "y" | $sdkmanager_path --sdk_root=$sdk_root ${split[0]}

# We copy only the relevant directories to a temporary dir
# for upload. sdkmanager creates extra files that we don't need.
array_length=${#split[@]}
Expand Down

0 comments on commit a284061

Please sign in to comment.