Skip to content

Commit

Permalink
use linear thumb resample filter
Browse files Browse the repository at this point in the history
  • Loading branch information
ganigeorgiev committed Dec 3, 2023
1 parent 04024cb commit f57d38f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@
- Added a default red colored Stderr output for the commands errors.
You can now also silence individually custom commands errors using the `cobra.Command.SilenceErrors` field.

- Slightly speed up (~10%) the thumbs generation by changing from cubic (`CatmullRom`) to bilinear (`Linear`) resampling filter (_the quality difference is very little_).


## v0.20.0-rc3

Expand Down
11 changes: 6 additions & 5 deletions tools/filesystem/filesystem.go
Original file line number Diff line number Diff line change
Expand Up @@ -425,25 +425,26 @@ func (s *System) CreateThumb(originalKey string, thumbKey, thumbSize string) err
return decodeErr
}

r.Close()
var thumbImg *image.NRGBA

if width == 0 || height == 0 {
// force resize preserving aspect ratio
thumbImg = imaging.Resize(img, width, height, imaging.CatmullRom)
thumbImg = imaging.Resize(img, width, height, imaging.Linear)
} else {
switch resizeType {
case "f":
// fit
thumbImg = imaging.Fit(img, width, height, imaging.CatmullRom)
thumbImg = imaging.Fit(img, width, height, imaging.Linear)
case "t":
// fill and crop from top
thumbImg = imaging.Fill(img, width, height, imaging.Top, imaging.CatmullRom)
thumbImg = imaging.Fill(img, width, height, imaging.Top, imaging.Linear)
case "b":
// fill and crop from bottom
thumbImg = imaging.Fill(img, width, height, imaging.Bottom, imaging.CatmullRom)
thumbImg = imaging.Fill(img, width, height, imaging.Bottom, imaging.Linear)
default:
// fill and crop from center
thumbImg = imaging.Fill(img, width, height, imaging.Center, imaging.CatmullRom)
thumbImg = imaging.Fill(img, width, height, imaging.Center, imaging.Linear)
}
}

Expand Down

0 comments on commit f57d38f

Please sign in to comment.