Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: code highlighting with hljs #148

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

ntno
Copy link
Owner

@ntno ntno commented Aug 14, 2024

wip for #81
todo: consider adding option to theme via feature flag
not sure whether we need this or we can just make a better example documentation

https://highlightjs.readthedocs.io/en/latest/readme.html#in-the-browser
https://highlightjs.readthedocs.io/en/latest/readme.html#common-js-omit-in-toc
https://highlightjs.org/download

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide before/after screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If there are existing unit and/or integration test suites, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
  • All active GitHub checks for tests, formatting, and security are passing

@ntno
Copy link
Owner Author

ntno commented Aug 14, 2024

Screen Shot 2024-08-13 at 11 19 05 PM
code highlighted but lost the custom background color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant