Cleanup Header

- Change ad type - Hide ad on scroll
nuagnorab · May 28, 2019 · c991d28 · c991d28
1 parent f5f3a23
commit c991d28
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/config/default.json b/config/default.json
@@ -157,6 +157,23 @@
       "dimensions": [[220, 90]]
     },
 
+    "top-navigation": {
+      "path": "/21784675435/steemit_top-navi",
+      "dimensions": [[728, 90], [970, 90]]
+    },
+    "top-navigation-loggedin-mobile": {
+      "path": "/21784675435/steemit_top-navi/steemit_top-navi_loggedin_mobile",
+      "dimensions": [[220, 90]]
+    },
+    "top-navigation-loggedin": {
+      "path": "/21784675435/steemit_top-navi/steemit_top-navi_loggedin",
+      "dimensions": [[728, 90], [970, 90]]
+    },
+    "top-navigation-mobile": {
+      "path": "/21784675435/steemit_top-navi/steemit_top-navi_mobile",
+      "dimensions": [[220, 90]]
+    },
+
     "left-navigation": {
       "path": "/21784675435/steemit_left-navigation/steemit_left-navigation_prebid",
       "dimensions": [[120, 600], [160, 600]]
@@ -166,6 +183,14 @@
     "prebid_timeout": 2000,
     "failsafe_timeout": 3000,
     "ad_units": [
+      {
+        "code": "/21784675435/steemit_top-navi",
+        "mediaTypes": { "banner": { "sizes": [[728, 90], [220, 90], [970, 90]] } },
+        "bids": [{
+          "bidder": "coinzilla",
+          "params": { "placementId": "6425c7b9886e0045972" }
+        }]
+      },
       {
         "code": "/21784675435/steemit_post-page-above-comments",
         "mediaTypes": { "banner": { "sizes": [[728, 90], [220, 90], [970, 90]] } },

diff --git a/src/app/components/elements/BiddingAd.jsx b/src/app/components/elements/BiddingAd.jsx
@@ -99,7 +99,6 @@ export default connect(
         const slotName = props.slotName;
         let type = props.type;
         let slot = state.app.getIn(['googleAds', `gpt${type}Slots`, slotName]);
-        console.log('Found slot for type', type, slot);
 
         return {
             enabled,

diff --git a/src/app/components/modules/Header/index.jsx b/src/app/components/modules/Header/index.jsx
@@ -19,7 +19,7 @@ import SteemLogo from 'app/components/elements/SteemLogo';
 import normalizeProfile from 'app/utils/NormalizeProfile';
 import Announcement from 'app/components/elements/Announcement';
 import { GptUtils } from 'app/utils/GptUtils';
-import GptAd from 'app/components/elements/GptAd';
+import BiddingAd from 'app/components/elements/BiddingAd';
 
 class Header extends React.Component {
     static propTypes = {
@@ -284,8 +284,8 @@ class Header extends React.Component {
                     )}
                     {/* If announcement is shown, ad will not render unless it's in a parent div! */}
                     <div>
-                        <GptAd
-                            type="Basic"
+                        <BiddingAd
+                            type="Bidding"
                             id="/21784675435/steemit_top-navi"
                             slotName={GptUtils.MobilizeSlotName(
                                 'top-navigation'