fix: Check nil values in container specification json #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that if we do not pass any memory specific argument in some versions of nerdctl then Linux.Resource.Memory object in container's config.json will be nil (not set). Therefore, we get nil dereference and golang traps. This PR checks for nil objects before retrieving the memory from container's config.json file. In addition, it simplifies the process of setting the VMM memory by removing the type conventions. Moreover, it checks the corner case of giving a too small memory (less than 1MB) PR: #67 Signed-off-by: Charalampos Mainas <[email protected]> Reviewed-by: Georgios Ntoutsos <[email protected]> Approved-by: Georgios Ntoutsos <[email protected]>
github-actions
bot
force-pushed
the
fix_reconfigurable_memory
branch
from
7da6793 to
c15050f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that if we do not pass any memory specific argument in some versions of nerdctl then Linux.Resource.Memory object in container's config.json will be nil (not set). Therefore, we get nil dereference and golang traps.
This PR checks for nil objects before retrieving the memory from container's config.json file. In addition, it simplifies the process of setting the VMM memory by removing the type conventions. Moreover, it checks the corner case of giving a too small memory (less than 1MB)