Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi_model_analysis command #215

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tylerbarna
Copy link
Collaborator

This is a command line function that will allow for users to provide multiple models/priors so they can all be run for one lightcurve at the same time and then directly compared against one another at the time of analysis. This is distinct from the existing functionality of light_curve_analysis and providing multiple models; the existing light_curve_analysis code allows for one to use a combination of multiple models to perform one analysis on a lightcurve (eg fitting a lightcurve to a mix of Model A and Model B, effectively Model A/B). This script would perform individual analysis of the lightcurve for each provided model and then compare the analyses against one another.

No actual functional code as of yet, but the scaffolding for a multi_model_analysis function has been created. There's a bunch of comments in the new file regarding implementation.

resolves #214

No actual functional code as of yet, but the scaffolding for a multi_model_analysis function has been created. There's a bunch of comments in the new file regarding implementation.
@tylerbarna tylerbarna added enhancement New feature or request help wanted Extra attention is needed labels Sep 4, 2023
@tylerbarna tylerbarna added this to the Analysis Tools milestone Sep 4, 2023
@mcoughlin mcoughlin requested review from bfhealy and Theodlz September 4, 2023 17:01
Copy link
Collaborator

@bfhealy bfhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerbarna This framework looks on the right track to facilitate multi-model analyses. Perhaps a good next step is to adapt your settings.json file in nmma-rapid to a config file in YAML format, as mentioned in today's meeting? Then YAML-parsing code could be added here to read all arguments.

It might be additionally helpful to add a script to generate a YAML file automatically. It could call analysis.py get_parser to get its arguments/defaults, ensuring that your YAML file has the latest inputs. After that, you could modify the YAML manually as desired before running multi_model_analysis.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

light_curve_analysis for multiple models
2 participants