prevent tests from changing config.debug flag

Fixes elastic#7962
nugend · Aug 10, 2017 · e28ceeb · e28ceeb
1 parent fb7f455
commit e28ceeb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/logstash-core/spec/logstash/pipeline_spec.rb b/logstash-core/spec/logstash/pipeline_spec.rb
@@ -120,7 +120,7 @@ class TestPipeline < LogStash::Pipeline
   let(:override_thread_count)   { 42 }
   let(:dead_letter_queue_enabled) { false }
   let(:dead_letter_queue_path) { }
-  let(:pipeline_settings_obj) { LogStash::SETTINGS }
+  let(:pipeline_settings_obj) { LogStash::SETTINGS.clone }
   let(:pipeline_settings) { {} }
   let(:max_retry) {10} #times
   let(:timeout) {120} #seconds
@@ -136,10 +136,6 @@ class TestPipeline < LogStash::Pipeline
     pipeline_settings.each {|k, v| pipeline_settings_obj.set(k, v) }
   end
 
-  after :each do
-    pipeline_settings_obj.reset
-  end
-
   describe "#ephemeral_id" do
     it "creates an ephemeral_id at creation time" do
       pipeline = mock_pipeline_from_string("input { generator { count =>  1 } } output { null {} }")

diff --git a/logstash-core/spec/logstash/runner_spec.rb b/logstash-core/spec/logstash/runner_spec.rb
@@ -294,6 +294,9 @@
     end
 
     describe "config.debug" do
+      after(:each) do
+        LogStash::SETTINGS.set("config.debug", false)
+      end
       it "should set 'config.debug' to false by default" do
         expect(LogStash::Agent).to receive(:new) do |settings|
           expect(settings.get("config.debug")).to eq(false)