assert fd != -1 in unmap path #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't even be trying to unmap if the region doesn't have an associated file descriptor. Signed-off-by: John Levon <[email protected]>
tmakatos
reviewed
Mar 17, 2021
There was a problem hiding this comment.
As per #391 (comment) I'm planning to always call _dma_controller_do_remove_region and we internally figure out whether or not there's cleanup to be done.
|
"internally figure out" - isn't that best in dma_controller_remove_region() ? I think the changes I have for this and: https://github.com/nutanix/libvfio-user/pull/394/files make sense no? |
|
I folded this into the big DMA PR #396, as so much has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't even be trying to unmap if the region doesn't have an associated
file descriptor.
Signed-off-by: John Levon [email protected]