Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only unmap regions that were actually mapped #408

Closed
wants to merge 1 commit into from

Conversation

jlevon
Copy link
Collaborator

@jlevon jlevon commented Mar 31, 2021

No description provided.

We weren't checking for ->virt_addr in the dma_controller_remove_regions() path.

Signed-off-by: John Levon <[email protected]>
@jlevon jlevon requested review from tmakatos and swapnili March 31, 2021 12:00
@jlevon jlevon marked this pull request as ready for review March 31, 2021 12:00
@jlevon
Copy link
Collaborator Author

jlevon commented Mar 31, 2021

NB: this is fixed in the dma branch too, but I needed this to do the reset work.

Copy link
Member

@tmakatos tmakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't then dma_controller_remove_region be unconditionally called by dma_controller_remove_region?

@jlevon
Copy link
Collaborator Author

jlevon commented Mar 31, 2021

dma changes are back, dropping this

@jlevon jlevon closed this Mar 31, 2021
@jlevon jlevon deleted the 2.dma-unmap-check branch December 21, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants