Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified traffic light icons to appear better in dark mode on Linux #658

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

pschmitz692
Copy link
Contributor

This is just a cosmetic change that fixes #296 by removing the white pixels around the traffic light icons so they appear cleaner when using dark mode and disabling native window frame on Linux.

@zjeffer
Copy link
Collaborator

zjeffer commented Dec 8, 2023

Can you post before and after pics of how this looks? It's not very clear what has changed by looking at the individual images in the commit.

Copy link
Collaborator

@guihkx guihkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, IMO.

Before:

dark-before

After:

dark-after

Copy link
Collaborator

@zjeffer zjeffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@nuttyartist
Copy link
Owner

That's a very welcome improvement, thanks! @pschmitz692

Merging...

@nuttyartist nuttyartist merged commit b4d8756 into nuttyartist:master Dec 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New traffic light icons needed that look better on Dark Mode on Linux
4 participants