-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create parent directories if not exist in generate mode #87
fix: create parent directories if not exist in generate mode #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 98.27% 98.38% +0.11%
==========================================
Files 2 2
Lines 58 62 +4
Branches 8 9 +1
==========================================
+ Hits 57 61 +4
Misses 1 1
Continue to review full report at Codecov.
|
Thanks a lot for the PR! Could you add a small test case for such a scenario as well? That'd be awesome 🙌 |
@manniL I'll try adding a test case for it as soon as I can |
@manniL did this ever get published? I'm still running into the issue on my repo. When I looked at the file in my |
@briancbarrow In the meantime, you can install it from the Git repo:
|
Will trigger a release this week 👍🏻 |
Hi @manniL! Has this PR been released yet? I got the same error earlier today. |
Make sure to create all parents directories for the output feed files in "generate mode".
Since commit 8832f39, the usage of
fs-extra.outputFile
has been replaced withfs.writeFileSync
. However, there is a subtle behavior change: whilefs-extra.outputFile
was creating all parent directories automatically,fs.writeFileSync
does not. Thus all parent directories need to be created if not present already.Resolves #85.