fix up colon test, add documentation for skipping it

nvichare · Jan 24, 2021 · 917b018 · 917b018
1 parent 0a02cfe
commit 917b018
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/named_test.go b/named_test.go
@@ -120,10 +120,11 @@ func (t Test) Errorf(err error, format string, args ...interface{}) {
 }
 
 func TestEscapedColons(t *testing.T) {
+	t.Skip("not sure it is possible to support this in general case without an SQL parser")
 	var qs = `SELECT * FROM testtable WHERE timeposted BETWEEN (now() AT TIME ZONE 'utc') AND
 	(now() AT TIME ZONE 'utc') - interval '01:30:00') AND name = '\'this is a test\'' and id = :id`
-	_, _, err := compileNamedQuery([]byte(qs), 3) //3 being DOLLAR
-	if err != nil{
+	_, _, err := compileNamedQuery([]byte(qs), DOLLAR)
+	if err != nil {
 		t.Error("Didn't handle colons correctly when inside a string")
 	}
 }