Skip to content

Commit

Permalink
[S390] list usage cleanup in s390
Browse files Browse the repository at this point in the history
Trivial cleanup, list_del(); list_add{,_tail}() is equivalent
to list_move{,_tail}(). Semantic patch for coccinelle can be
found at www.cccmz.de/~snakebyte/list_move_tail.spatch

Signed-off-by: Eric Sesterhenn <[email protected]>
Signed-off-by: Martin Schwidefsky <[email protected]>
  • Loading branch information
SesterhennEric authored and Martin Schwidefsky committed Mar 26, 2009
1 parent ab640db commit 1fbc9f4
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/s390/crypto/zcrypt_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ static void __zcrypt_increase_preference(struct zcrypt_device *zdev)
if (l == zdev->list.prev)
return;
/* Move zdev behind l */
list_del(&zdev->list);
list_add(&zdev->list, l);
list_move(&zdev->list, l);
}

/**
Expand Down Expand Up @@ -157,8 +156,7 @@ static void __zcrypt_decrease_preference(struct zcrypt_device *zdev)
if (l == zdev->list.next)
return;
/* Move zdev before l */
list_del(&zdev->list);
list_add_tail(&zdev->list, l);
list_move_tail(&zdev->list, l);
}

static void zcrypt_device_release(struct kref *kref)
Expand Down

0 comments on commit 1fbc9f4

Please sign in to comment.