Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the title to an image #32

Closed
ianmah opened this issue Sep 27, 2020 · 0 comments · Fixed by #36
Closed

Change the title to an image #32

ianmah opened this issue Sep 27, 2020 · 0 comments · Fixed by #36
Labels
gud first issue Good for newcomers Hecctoberfest

Comments

@ianmah
Copy link
Contributor

ianmah commented Sep 27, 2020

Currently the livesite uses a text title in the sidebar. The design calls for an image!
This ticket involves changing the text to an image

image
saadbaigg added a commit to saadbaigg/livesite that referenced this issue Sep 27, 2020
@saadbaigg
Change the title to an image (issue nwplus#32)
5dddd99 
- Created a new folder named 'assets' in livesite/src/
- Added provided SVG in livesite/src/assets
- Replaced text with SVG in Sidebar.js
@ianmah ianmah linked a pull request Sep 27, 2020 that will close this issue
Change the title to an image (issue #32) #36
Merged
ianmah added a commit that referenced this issue Sep 27, 2020
@ianmah
Merge pull request #36 from 7-baig/fix_issue_#32
242ba7f 
Change the title to an image (issue #32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gud first issue Good for newcomers Hecctoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the title to an image (issue #32) saadbaigg/livesite
1 participant
@ianmah