Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the title to an image (issue #32) #36

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Change the title to an image (issue #32) #36

merged 2 commits into from
Sep 27, 2020

Conversation

saadbaigg
Copy link
Contributor

  • Created a new folder named 'assets' in livesite/src/
  • Added provided SVG in livesite/src/assets
  • Replaced text with SVG in Sidebar.js

@saadbaigg
Change the title to an image (issue nwplus#32)
5dddd99 
- Created a new folder named 'assets' in livesite/src/
- Added provided SVG in livesite/src/assets
- Replaced text with SVG in Sidebar.js
ianmah
ianmah suggested changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@ianmah ianmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉
Noticed a new file package-lock.json was created. We use yarn in this repo instead of npm. Yarn uses yarn.lock instead of package-lock.json. Could you delete the package-lock.json?

@saadbaigg
Copy link
Contributor Author

Yeah sure! I can do it.

@saadbaigg
Copy link
Contributor Author

Done!

@ianmah ianmah linked an issue Sep 27, 2020 that may be closed by this pull request
Change the title to an image #32
Closed
ianmah
ianmah approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@ianmah ianmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@ianmah ianmah merged commit 242ba7f into nwplus:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmah ianmah ianmah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the title to an image
2 participants
@saadbaigg @ianmah