Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HK Grotesk #10

Merged
merged 2 commits into from
Aug 2, 2020
Merged

Add HK Grotesk #10

merged 2 commits into from
Aug 2, 2020

Conversation

jackyzha0
Copy link
Contributor

@jackyzha0 jackyzha0 commented Jul 31, 2020 •
edited
Loading

closes #2

@jackyzha0 jackyzha0 requested a review from ianmah July 31, 2020 07:18
ianmah
ianmah reviewed Aug 1, 2020
View reviewed changes
src/theme/GlobalStyle.js Outdated
@@ -1,7 +1,9 @@
import { createGlobalStyle } from 'styled-components';
import "./fonts/style.css"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use '

ianmah
ianmah reviewed Aug 1, 2020
View reviewed changes
Copy link
Contributor

@ianmah ianmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:seemsgood: for now, would like to switch to CDN once a blessed nw solution is found. Otherwise, consider tabbing inside style.css?

@jackyzha0 jackyzha0 requested a review from ianmah August 1, 2020 16:55
@jackyzha0 jackyzha0 merged commit 8f4b1c3 into master Aug 2, 2020
@jackyzha0 jackyzha0 deleted the font branch August 2, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmah ianmah ianmah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HK Grotesk
2 participants
@jackyzha0 @ianmah