Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added question heading component #133

Merged
merged 2 commits into from
Nov 27, 2020
Merged

added question heading component #133

merged 2 commits into from
Nov 27, 2020

Conversation

shuting-hu
Copy link
Contributor

issue #121

  • primary themed heading component
  • to be used for question headings on application

Screen Shot 2020-11-26 at 8 38 44 PM

@shuting-hu shuting-hu requested a review from panjenny0 November 27, 2020 04:41
@github-actions
Copy link

github-actions bot commented Nov 27, 2020 •
edited
Loading

Visit the preview URL for this PR (updated for commit f17071c):

https://nwplus-ubc--pr133-qheading-hnsbfybn.web.app

(expires Fri, 04 Dec 2020 07:11:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@shuting-hu shuting-hu linked an issue Nov 27, 2020 that may be closed by this pull request
Typography: question heading #121
Closed
panjenny0
panjenny0 previously approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@panjenny0 panjenny0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good job :))

@panjenny0 panjenny0 self-requested a review November 27, 2020 06:59
panjenny0
panjenny0 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@panjenny0 panjenny0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@panjenny0 panjenny0 merged commit 804909b into master Nov 27, 2020
@ianmah ianmah deleted the qheading branch November 28, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panjenny0 panjenny0 panjenny0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typography: question heading
2 participants
@shuting-hu @panjenny0