Reduce Firebase reads #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 86448b7): https://nwplus-ubc--pr203-reduce-reads-iqm17ol2.web.app (expires Sun, 13 Dec 2020 11:22:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
jackyzha0
reviewed
Dec 6, 2020
src/containers/Announcements.js
Outdated
Comment on lines
14
to
16
| .orderBy('timestamp', 'desc') | ||
| .limit(6) | ||
| .onSnapshot(querySnapshot => { |
There was a problem hiding this comment.
can we reuse the data fetched from src/App.js:L117?
There was a problem hiding this comment.
let's get someone with iOS to test the preview pr to make sure my changes didn't break the homepage before we merge. @acchiang? Can you make sure you still see announcements on the homepage
There was a problem hiding this comment.
just got carmen to test on iOS, looks good
| return db | ||
| .collection(DB_COLLECTION) | ||
| .doc(DB_HACKATHON) | ||
| .collection('QuickLinks') | ||
| .where('common', '==', true) |
jackyzha0
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.