Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad at js #207

Merged
merged 2 commits into from
Dec 7, 2020
Merged

bad at js #207

merged 2 commits into from
Dec 7, 2020

Conversation

Ciuffi
Copy link
Contributor

@Ciuffi Ciuffi commented Dec 7, 2020

I used contains which doesn't exist. Changed to includes.

jackyzha0
jackyzha0 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@jackyzha0 jackyzha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@github-actions
Copy link

github-actions bot commented Dec 7, 2020 •
edited
Loading

Visit the preview URL for this PR (updated for commit a90b2cf):

https://nwplus-ubc--pr207-auth-fix-0dsfd7x5.web.app

(expires Mon, 14 Dec 2020 03:16:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@acchiang
Copy link
Contributor

acchiang commented Dec 7, 2020 •
edited
Loading

gonna test staging, one sec
edit: looks good but judging page is empty, not sure if thats bad, will check w ian

@acchiang acchiang merged commit 8d79c94 into master Dec 7, 2020
@acchiang acchiang deleted the auth-fix branch December 7, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyzha0 jackyzha0 jackyzha0 approved these changes

@ianmah ianmah Awaiting requested review from ianmah

@acchiang acchiang Awaiting requested review from acchiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ciuffi @acchiang @jackyzha0