Set up routing for judging #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2f61de1): https://nwplus-ubc--pr78-judging-routing-1wndjvts.web.app (expires Fri, 13 Nov 2020 03:09:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
jackyzha0
reviewed
Nov 6, 2020
src/components/Page.js
Outdated
| const [isJudgingEnabled, setIsJudgingEnabled] = useState(false) | ||
|
|
||
| useEffect(() => { | ||
| const unsubscribe = isJudgingOpen(setIsJudgingEnabled) |
There was a problem hiding this comment.
why the name change from isJudgingOpen to isJudgingDisabled?
There was a problem hiding this comment.
idk its overlapping with the firebase utility function name
jackyzha0
reviewed
Nov 6, 2020
src/components/Page.js
Outdated
| import styled from 'styled-components' | ||
| import Sidebar from './Sidebar' | ||
| import MobileMenuBar from './MobileMenuBar' | ||
| import { isJudgingOpen } from '../utility/firebase' |
There was a problem hiding this comment.
alternatively, we can do import as here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
Creates new routes
/judging/judging/view/:id/judging/doneOnly includes JUDGING in sidebar when judging is open