hc bRanD reFrEsH #94
Merged
hc bRanD reFrEsH #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jackyzha0
commented
Nov 15, 2020
jackyzha0
commented
- made some colours more consistent
- hc theme yeet
|
Visit the preview URL for this PR (updated for commit 7214026): https://nwplus-ubc--pr94-hc-brand-refresh-vwubfyq4.web.app (expires Sun, 22 Nov 2020 03:25:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
ianmah
reviewed
Nov 15, 2020
src/components/Sidebar.js
Outdated
|
|
||
| ${p => | ||
| p.theme.custom_imgs === 'hc' && | ||
| css` |
There was a problem hiding this comment.
HC logo is more rectangle than square, so just fixing width and padding to make it look nicer
There was a problem hiding this comment.
You can't do that without the css import?
There was a problem hiding this comment.
how else should i do the conditional css bit?
There was a problem hiding this comment.
does this not work
${p =>
p.theme.custom_imgs === 'hc' &&
`
width: 120px;
margin: 30px 0 0px 60px;
`}
`
ianmah
reviewed
Nov 15, 2020
|
|
||
| ${p => | ||
| p.theme.custom_imgs === 'hc' && | ||
| css` |
There was a problem hiding this comment.
this file already imports css so i think it should be fine lol
ianmah
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.