Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed render sizes and SDL_RenderSetLogicalSize for scaling #275

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Use fixed render sizes and SDL_RenderSetLogicalSize for scaling #275

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9176d1c
Use SDL_WINDOW_FULLSCREEN_DESKTOP for fullscreen mode
xordspar0 Oct 13, 2022
b3738aa
Set the correct render size when switching to fullscreen
xordspar0 Oct 13, 2022
0c0c05b
Always render at the base size; let SDL scale for us
xordspar0 Oct 13, 2022
323e4b2
Allow high DPI
xordspar0 Oct 13, 2022
8cdbd62
Don't hardcode dimensions
xordspar0 Oct 13, 2022
775e0e2
Clean up extra ()
xordspar0 Oct 13, 2022
b73b43a
Update inventory position every frame
xordspar0 Oct 25, 2022
7b3a5cf
Factor out scale field
xordspar0 Oct 25, 2022
462e076
Don't adjust the save select menu y position based on widescreen mode
xordspar0 Oct 25, 2022
b042789
Factor out duplicate code
xordspar0 Oct 25, 2022
fdbcf01
Call SDL_RenderClear once per frame
xordspar0 Oct 29, 2022
e49d109
Automatically calculate the camera position for skinny maps
xordspar0 Nov 11, 2022
8f90b14
Correct centering for maps thinner than the screen
xordspar0 Nov 27, 2022
b7bd4e8
Don't use a custom resolution for Switch
xordspar0 Nov 27, 2022
6a1768d
Render to a small texture, then scale up to the screen size
xordspar0 Nov 28, 2022
15e475f
Factor out duplicate code between initVideo and setResolution
xordspar0 Nov 28, 2022
6fe41c8
Fix uninitialized memory error
xordspar0 Sep 30, 2023
5fb1179
Merge branch 'master' into camera-dimensions
xordspar0 Dec 29, 2023
56e9b27
Merge branch 'master' into camera-dimensions
xordspar0 Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Factor out duplicate code between initVideo and setResolution
  • Loading branch information
@xordspar0
xordspar0 committed Apr 26, 2023
commit 15e475f5a40d7204b9cd7121d20b764c3289abd2
53 changes: 19 additions & 34 deletions src/graphics/Renderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,6 @@ bool Renderer::initVideo(int scale)
{
uint32_t window_flags = SDL_WINDOW_SHOWN | SDL_WINDOW_ALLOW_HIGHDPI;

//TODO: sync this with setResolution
if (widescreen) {
screenWidth = 432;
screenHeight = 243;
} else {
screenWidth = 320;
screenHeight = 240;
}

if (_window)
{
LOG_WARN("second call to Renderer::InitVideo()");
Expand Down Expand Up @@ -133,13 +124,7 @@ bool Renderer::initVideo(int scale)

LOG_INFO("Renderer::initVideo: using: {} renderer", info.name);

if (SDL_RenderSetLogicalSize(_renderer, screenWidth, screenHeight))
{
LOG_ERROR("Renderer::initVideo: SDL_RenderSetLogicalSize failed: {}", SDL_GetError());
return false;
}

if (!createRenderTarget(screenWidth, screenHeight))
if (!setResolution(scale, widescreen))
return false;

std::string spotpath = ResourceManager::getInstance()->getPath("spot.png");
Expand All @@ -152,24 +137,6 @@ bool Renderer::initVideo(int scale)
return true;
}

bool Renderer::createRenderTarget(int width, int height)
{
SDL_RendererInfo info;
SDL_GetRendererInfo(_renderer, &info);

_texture = SDL_CreateTexture(_renderer,
info.texture_formats[0],
SDL_TEXTUREACCESS_TARGET,
width, height);
if (SDL_SetRenderTarget(_renderer, _texture)) {
LOG_ERROR("Renderer::createRenderTarget: SDL_SetRenderTarget failed: {}", SDL_GetError());
return false;
}
SDL_RenderClear(_renderer);

return true;
}

bool Renderer::flushAll()
{
LOG_DEBUG("Renderer::flushAll()");
Expand Down Expand Up @@ -255,6 +222,24 @@ int Renderer::getResolutionCount()
#endif
}

bool Renderer::createRenderTarget(int width, int height)
{
SDL_RendererInfo info;
SDL_GetRendererInfo(_renderer, &info);

_texture = SDL_CreateTexture(_renderer,
info.texture_formats[0],
SDL_TEXTUREACCESS_TARGET,
width, height);
if (SDL_SetRenderTarget(_renderer, _texture)) {
LOG_ERROR("Renderer::createRenderTarget: SDL_SetRenderTarget failed: {}", SDL_GetError());
return false;
}
SDL_RenderClear(_renderer);

return true;
}

void Renderer::showLoadingScreen()
{
Surface loading;
Expand Down