Clarify key values in upsert along navigation properties #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ralfhandl
commented
Apr 22, 2024
•
ralfhandl
commented
- Fixes Clarify key values in upsert along navigation properties #402
HeikoTheissen
previously approved these changes
Apr 22, 2024
HeikoTheissen
requested changes
May 24, 2024
HeikoTheissen
previously approved these changes
May 24, 2024
ralfhandl
commented
May 29, 2024
ralfhandl
commented
May 29, 2024
ralfhandl
commented
Jun 3, 2024
ralfhandl
commented
Jun 5, 2024
This reverts commit 3aca20c.
2 tasks
ralfhandl
commented
Jul 19, 2024
Comment on lines
-580
to
-582
| Key and other non-updatable properties, as well as dependent properties | ||
| that are not tied to key properties of the principal entity, MUST be | ||
| ignored by the service in processing the Upsert request. |
There was a problem hiding this comment.
The non-updatable etc. part is already covered in the sections on insert and update, and improvements to those sections are proposed in #1968
|
Split up overly large PR that has been sitting around for too long. |
HeikoTheissen
requested changes
Jul 19, 2024
HeikoTheissen
approved these changes
Jul 19, 2024
ralfhandl
deleted the
402/key-values-in-upserts-along-navigation-properties
branch
ralfhandl
added a commit
that referenced
this pull request
Jul 31, 2024
- [x] Fixes #356 - [x] Fixes #357 - includes #1924 --------- Co-authored-by: Heiko Theißen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.