Enhancements for Windows and macOS. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a number of private classes to deal with Tcl/Tk/tkinter idiosyncrasies and differences on Windows and macOS. On macOS, most tkinter calls seem delayed making it necessary to wrap those as events (using the tkinter.after* function). Changed the anchoring of the buttons and video panel by making both separate, movable windows. Dragging and resizing each window now works smoothly and correctly on Windows and macOS. Added menu options to change zoom, rate and opacity. However, the zoom and rate items are disabled on macOS due to poor behavior (still unresolved).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a number of private classes to deal with
Tcl/Tk/tkinteridiosyncrasies and differences on Windows and macOS.On macOS, most
tkintercalls seem delayed making it necessary to morph such calls into events (withtkinter.after*functions).Changed the anchoring of the buttons and video panel by making both separate, movable windows. Dragging and resizing each window now works smoothly and correctly on Windows and macOS.
Added menu options to change zoom, rate and opacity. However, the zoom and rate items are disabled on macOS due to poor behavior (still unresolved).