Skip to content

Commit

Permalink
dev: fix ssj ci resources (kkrt-labs#1599)
Browse files Browse the repository at this point in the history
<!--- Please provide a general summary of your changes in the title
above -->
**Fixed bug in `kakarot_scripts/check_resources.py` with wrong and not
needed parameter.**

<!-- Give an estimate of the time you spent on this PR in terms of work
days.
Did you spend 0.5 days on this PR or rather 2 days?  -->

Time spent on this PR:
**0.1 day (2-3 hours)**

## Pull request type

<!-- Please try to limit your pull request to one type,
submit multiple pull requests if needed. -->

Please check the type of change your PR introduces:

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [x] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying,
or link to a relevant issue. -->

Resolves kkrt-labs#1597

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

- `make check-resources` now works without any bugs.

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1599)
<!-- Reviewable:end -->
  • Loading branch information
vitaliypopel authored Nov 9, 2024
1 parent 9b728ec commit f87b89e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion kakarot_scripts/setup/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ def setup_local() -> None:
run_command(
f"git clone https://github.com/asdf-vm/asdf.git ~/.asdf --branch {ASDF_VERSION}",
"Failed to install asdf",
version=ASDF_VERSION,
)
shell_config = get_shell_config_file()
if shell_config:
Expand Down

0 comments on commit f87b89e

Please sign in to comment.