Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCaml 4.12 #191

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Add support for OCaml 4.12 #191

merged 4 commits into from
Oct 23, 2020

Conversation

kit-ty-kate
Copy link
Contributor

@kit-ty-kate kit-ty-kate commented Oct 19, 2020

This requires the OCaml 4.12 support in omp to be merged first: ocaml-ppx/ocaml-migrate-parsetree#107

This is just a PR to make ppxlib compile in case someone needs to test packages requiring ppxlib with OCaml 4.12. I do not know the internal nor have i tested if the tests ran correctly.

This branch will temporary be used in opam-alpha-repository

@kit-ty-kate kit-ty-kate requested a review from xclerc as a code owner October 19, 2020 17:25
@kit-ty-kate
Copy link
Contributor Author

kit-ty-kate commented Oct 19, 2020

I did not use cinaps to generate this, however when I tried to use it, it failed with the following warning/error and failed to produce ast/versions.mli file:

File "ast/versions.mli", line 131, characters 23-32:
Error (warning 49 [no-cmi-file]): no cmi file was found in path for module OCaml_412

Is that something to do with ocaml-ppx/ocaml-migrate-parsetree#107 maybe?

@NathanReb
Copy link
Collaborator

I did not use cinaps to generate this, however when I tried to use it, it failed with the following warning/error and failed to produce ast/versions.mli file:

File "ast/versions.mli", line 131, characters 23-32:
Error (warning 49 [no-cmi-file]): no cmi file was found in path for module OCaml_412

Is that something to do with ocaml-ppx/ocaml-migrate-parsetree#107 maybe?

I tried it locally myself and it seems to work just fine. I did get a few errors but that's probably related to the fact that you have to promote multiple times. After a couple dune runtest && dune promote runs, both the ml and mli files were updated and everything builds and passes the test!

Thanks for working on this, I'll merge as soon as we release the corresponding ocaml-migrate-parsetree!

@NathanReb
Copy link
Collaborator

Can you allow push from maintainers please? I'd like to update a couple things like the changelog and the opam file.

@NathanReb
Copy link
Collaborator

Nevermind I was doing it all wrong!

@NathanReb NathanReb force-pushed the 412 branch 2 times, most recently from 9616bf7 to eeb0b30 Compare October 23, 2020 08:21
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
@NathanReb NathanReb merged commit 6f89e0e into ocaml-ppx:master Oct 23, 2020
NathanReb added a commit to NathanReb/opam-repository that referenced this pull request Oct 23, 2020
CHANGES:

- Make ppxlib compatible with 4.12 compiler (ocaml-ppx/ppxlib#191, @kit-ty-kate)
@kit-ty-kate kit-ty-kate deleted the 412 branch November 8, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants