-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCaml 4.12 #191
Conversation
Signed-off-by: Kate <[email protected]>
I did not use
Is that something to do with ocaml-ppx/ocaml-migrate-parsetree#107 maybe? |
I tried it locally myself and it seems to work just fine. I did get a few errors but that's probably related to the fact that you have to promote multiple times. After a couple Thanks for working on this, I'll merge as soon as we release the corresponding |
Can you allow push from maintainers please? I'd like to update a couple things like the changelog and the opam file. |
Nevermind I was doing it all wrong! |
Signed-off-by: Nathan Rebours <[email protected]>
9616bf7
to
eeb0b30
Compare
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
CHANGES: - Make ppxlib compatible with 4.12 compiler (ocaml-ppx/ppxlib#191, @kit-ty-kate)
This requires the OCaml 4.12 support in omp to be merged first: ocaml-ppx/ocaml-migrate-parsetree#107
This is just a PR to make ppxlib compile in case someone needs to test packages requiring ppxlib with OCaml 4.12. I do not know the internal nor have i tested if the tests ran correctly.
This branch will temporary be used in opam-alpha-repository