Skip to content

Commit

Permalink
MAINT: Disable checks for Win workaround for GCC (numpy#21881)
Browse files Browse the repository at this point in the history
* Disable checks for Win workaround for GCC

Python compiled with GCC on Windows does not suffer the same
deficiencies as MSVC; disable check for that platform.

Here are a couple of `sys.version` strings from Windows / Mingw-w64
Python binaries:

* '3.10.5 (main, Jun 18 2022, 01:33:07)  [GCC 12.1.0 32 bit]'
* '3.10.5 (main, Jun 18 2022, 01:32:32)  [GCC UCRT 12.1.0 64 bit (AMD64)]'

For MSVC Python binaries:

* '3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:24:45) [MSC v.1929 32 bit (Intel)]'
* '3.10.5 (tags/v3.10.5:f377153, Jun  6 2022, 16:14:13) [MSC v.1929 64 bit (AMD64)]'

* Update numpy/core/tests/test_multiarray.py
  • Loading branch information
matthew-brett authored Jun 30, 2022
1 parent f9bed20 commit 0fa4f0f
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions numpy/core/tests/test_multiarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -5497,10 +5497,12 @@ def test_binary(self, tmp_filename):

@pytest.mark.slow # takes > 1 minute on mechanical hard drive
def test_big_binary(self):
"""Test workarounds for 32-bit limited fwrite, fseek, and ftell
calls in windows. These normally would hang doing something like this.
See http://projects.scipy.org/numpy/ticket/1660"""
if sys.platform != 'win32':
"""Test workarounds for 32-bit limit for MSVC fwrite, fseek, and ftell
These normally would hang doing something like this.
See : https://github.com/numpy/numpy/issues/2256
"""
if sys.platform != 'win32' or '[GCC ' in sys.version:
return
try:
# before workarounds, only up to 2**32-1 worked
Expand Down

0 comments on commit 0fa4f0f

Please sign in to comment.