Add recursive delete of files and folders after installation is finished #97
Conversation
There was a problem hiding this comment.
LGTM, testing needed still though. @w20k can you take a look?
|
@LukeTowers, sure! Will run a few tests, tomorrow! |
|
@LukeTowers works fine, but one minor fix should be added. It doesn't remove Screenshot: |
|
@Samuell1 could you look into that please? |
|
@LukeTowers i think we should move install.log from install_files folder to root. |
w20k
added
Status: Blocked
Status: Testing Needed
and removed
Status: Response Needed
labels
|
@Samuell1 tried your latest fix. Now install.log is there, install.php was removed, but |
|
Under what conditions would you retain install.log but not retain the install files? AFAIK install.log is just for if there was an error preventing the installation from completing, in which case you would not want to remove the install_files? |
|
@LukeTowers install.log is not created only on errors but after every step. |
|
@Samuell1 so if there are any errors period the installation will not complete and the files will not be removed? If that's the case then I would prefer that a fully clean install.log (i.e. no errors) just gets removed along with the rest of the installation files. |
|
I think it should work like that now. |
|
@Samuell1 So you can verify that after the install process is successfully completed all install files (install_files directory, install.log, install.php) are completely removed? |
|
@Samuell1 ping me if re-test is needed. |
|
@w20k You can if you have time but i tested it yesterday and works great. I sended a video of steps to @LukeTowers privately. |
|
@w20k can you test what happens if the install fails at any point before or during the cleanInstall step? I would like to get rid of the notice at the end telling people to clean up after the installer but I don't want to remove it outright if we aren't handling failure cases properly (such as error during install or incorrect permissions to remove the files required to clean up after the installation process) |
|
Sure @LukeTowers will do! |
|
@LukeTowers if cleaning of files will throw error it will silently continue. |
Resolves octobercms/october#4274