Adds forbidden exception

Refactor custom exceptions

helpers/ForbiddenException.php

@@ -0,0 +1,8 @@
+<?php
+
+/**
+ * ForbiddenException
+ *
+ * @see October\Rain\Exception\ForbiddenException
+ */
+class ForbiddenException extends October\Rain\Exception\ForbiddenException {}

src/Exception/ErrorHandler.php

@@ -59,18 +59,8 @@ public function handleException(Throwable $proposedException)
             ob_end_clean();
         }
 
-        // Not found exceptions
-        if ($this->isNotFoundException($proposedException)) {
-            // Friendly 404 pages are used
-            if (($customNotFound = $this->handleCustomNotFound()) !== null) {
-                return $customNotFound;
-            }
-
-            return;
-        }
-
         // Friendly error pages are used
-        if (($customError = $this->handleCustomError()) !== null) {
+        if (($customError = $this->handleCustomError($proposedException)) !== null) {
             return $customError;
         }
 
@@ -161,18 +151,9 @@ public function beforeHandleError($exception)
     /**
      * handleCustomError checks if using a custom error page, if so return the contents.
      * Return NULL if a custom error is not set up.
-     * @return mixed Error page contents.
-     */
-    public function handleCustomError()
-    {
-    }
-
-    /**
-     * handleCustomNotFound checks if using a custom 404 page, if so return the contents.
-     * Return NULL if a custom 404 is not set up.
-     * @return mixed 404 page contents.
+     * @return mixed
      */
-    public function handleCustomNotFound()
+    public function handleCustomError($exception)
     {
     }
 

src/Exception/ForbiddenException.php

@@ -0,0 +1,12 @@
+<?php namespace October\Rain\Exception;
+
+/**
+ * ForbiddenException represents a permission denied exception and
+ * these will redirect to the nearest access denied / 403 page.
+ *
+ * @package october\exception
+ * @author Alexey Bobkov, Samuel Georges
+ */
+class ForbiddenException extends ExceptionBase
+{
+}

src/Foundation/Exception/Handler.php

@@ -7,6 +7,7 @@
 use Illuminate\Contracts\Support\Responsable;
 use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+use October\Rain\Exception\ForbiddenException;
 use October\Rain\Exception\NotFoundException;
 use October\Rain\Exception\AjaxException;
 use ReflectionFunction;
@@ -166,6 +167,9 @@ protected function getStatusCode($exception)
         if ($exception instanceof HttpExceptionInterface) {
             $code = $exception->getStatusCode();
         }
+        elseif ($exception instanceof ForbiddenException) {
+            $code = 403;
+        }
         elseif ($exception instanceof AjaxException) {
             $code = 406;
         }