Add auto_ttl config parameter. #116
Conversation
octodns_cloudflare/__init__.py
Outdated
| @@ -862,7 +864,7 @@ def _record_is_just_auto_ttl(self, record): | |||
| return ( | |||
| not self._record_is_proxied(record) | |||
| and not self.cdn | |||
| and record._octodns.get('cloudflare', {}).get('auto-ttl', False) | |||
| and record._octodns.get('cloudflare', {}).get('auto-ttl', record.source != self and record._type != 'URLFWD' and self.auto_ttl) | |||
There was a problem hiding this comment.
The record.source != self and URLFWD checks are worthy of an explanations/comments I would have expected this to just have the self.auto_ttl bit. Guessing the other clauses may be more general. Might also make sense to pull all of the default value stuff out into its own assignment before the return statement and just use that value here. Line is getting pretty long and multi-leveled.
There was a problem hiding this comment.
These performs checks on the record's context as _record_is_just_auto_ttl is used in a few different contexts.
URLFWD records do not utilize ttl. This mirrors other sections which ignore ttl for URLFWD records.
_record_is_just_auto_ttl is used to check the status of the auto-ttl flag on the live record on Cloudflare and the source record from other providers. The record.source != self ensures that we don't default records from Cloudflare to true, as we want the actual value in that case.
There was a problem hiding this comment.
Cool. Those explanations make sense. If you don't mind please move them into comments along with the code changes.
The Cloudflare dashboard uses Auto TTL by default for new records. This change adds a config parameter to use auto-ttl: true for all records by default.