forked from netty/netty
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OpenSslEngine: Remove renegotiation support
Motivation: SSL.setState() has gone from openssl 1.1. Calling it is, and probably always has been, incorrect. Doing renogitation in this manner is potentially insecure. There have been at least two insecure renegotiation vulnerabilities in users of the OpenSSL library. Renegotiation is not necessary for correct operation of the TLS protocol. BoringSSL has already eliminated this functionality, and the tests (now deleted) were not running on BoringSSL. Modifications: If the connection setup has completed, always return that negotiation is not supported. Previously this was done only if we were the client. Remove the tests for this functionality. Fixes netty#6320.
- Loading branch information
1 parent
2b4f667
commit e24e06b
Showing
3 changed files
with
1 addition
and
108 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
handler/src/test/java/io/netty/handler/ssl/OpenSslRenegotiateSmallBIOTest.java
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
handler/src/test/java/io/netty/handler/ssl/OpenSslRenegotiateTest.java
This file was deleted.
Oops, something went wrong.