builtin-fetch--tool: fix reflog notes.

Also the verbose output had unnecessary SHA1 and not-for-merge markers leaked because append_fetch_head() cheated Signed-off-by: Junio C Hamano <[email protected]>
ogay · Mar 1, 2007 · 855b346 · 855b346
1 parent e6eebbb
commit 855b346
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/builtin-fetch--tool.c b/builtin-fetch--tool.c
@@ -181,16 +181,18 @@ static int append_fetch_head(FILE *fp,
 	remote_len = i + 1;
 	if (4 < i && !strncmp(".git", remote + i - 3, 4))
 		remote_len = i - 3;
-	note_len = sprintf(note, "%s\t%s\t",
-			   sha1_to_hex(commit ? commit->object.sha1 : sha1),
-			   not_for_merge ? "not-for-merge" : "");
+
+	note_len = 0;
 	if (*what) {
 		if (*kind)
 			note_len += sprintf(note + note_len, "%s ", kind);
 		note_len += sprintf(note + note_len, "'%s' of ", what);
 	}
 	note_len += sprintf(note + note_len, "%.*s", remote_len, remote);
-	fprintf(fp, "%s\n", note);
+	fprintf(fp, "%s\t%s\t%s\n",
+		sha1_to_hex(commit ? commit->object.sha1 : sha1),
+		not_for_merge ? "not-for-merge" : "",
+		note);
 	return update_local_ref(local_name, head, note, verbose, force);
 }